Skip to content

Conversation

@leon-inf
Copy link
Contributor

close #9922

@leon-inf leon-inf added this to the Release 1.1.0 milestone Dec 16, 2025
@leon-inf leon-inf requested a review from a team as a code owner December 16, 2025 09:56
@leon-inf
Copy link
Contributor Author

/nopick

@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 16, 2025
@apecloud-bot apecloud-bot added the nopick Not auto cherry-pick when PR merged label Dec 16, 2025
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.28%. Comparing base (1cd2f9c) to head (cc2543f).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ollers/apps/rollout/transformer_rollout_replace.go 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9937      +/-   ##
==========================================
+ Coverage   51.06%   51.28%   +0.21%     
==========================================
  Files         541      541              
  Lines       58340    58507     +167     
==========================================
+ Hits        29793    30006     +213     
+ Misses      25611    25565      -46     
  Partials     2936     2936              
Flag Coverage Δ
unittests 51.28% <50.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Dec 26, 2025
@leon-inf
Copy link
Contributor Author

/approve

@leon-inf leon-inf merged commit 80b245d into main Dec 29, 2025
51 checks passed
@leon-inf leon-inf deleted the bugfix/sharding-rollout-replicas branch December 29, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test nopick Not auto cherry-pick when PR merged size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Invalid Rollout Replicas for Sharding

5 participants