Skip to content

fix(dataprotection): prevent infinite job creation loop during backup foreground deletion #9958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangyelei merged 1 commit into from
Dec 25, 2025
Merged

fix(dataprotection): prevent infinite job creation loop during backup foreground deletion #9958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions controllers/dataprotection/backup_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,13 @@ func (r *BackupReconciler) parseBackupJob(_ context.Context, object client.Objec

// deleteBackupFiles deletes the backup files stored in backup repository.
func (r *BackupReconciler) deleteBackupFiles(reqCtx intctrlutil.RequestCtx, backup *dpv1alpha1.Backup) error {
// If the dataprotection finalizer has already been removed, the deletion has succeeded.
// Skip creating a new deletion job to avoid a race condition with the garbage collector
// during foreground cascading deletion, which would cause an infinite loop of job creation.
if !controllerutil.ContainsFinalizer(backup, dptypes.DataProtectionFinalizerName) {
return nil
}

deleteBackup := func() error {
// remove backup finalizers to delete it
patch := client.MergeFrom(backup.DeepCopy())
Expand Down
Loading