-
Notifications
You must be signed in to change notification settings - Fork 250
chore: rollback service account name when upgrading componentdefinition #9967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rollback service account name when upgrading componentdefinition #9967
Conversation
|
Auto Cherry-pick Instructions |
| synthesizedComp.PodSpec.ServiceAccountName = serviceAccountName | ||
| if lastServiceAccountName != serviceAccountName || lastHash != hash { | ||
| comp.Labels[constant.ComponentLastServiceAccountNameLabelKey] = serviceAccountName | ||
| comp.Labels[constant.ComponentLastServiceAccountRuleHashLabelKey] = hash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using the SA object to carry the rule hash? the SA name can be obtained from the ITS object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting annotations in component is simpler. But I can change it to SA object if you like.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9967 +/- ##
==========================================
+ Coverage 51.04% 51.24% +0.19%
==========================================
Files 541 541
Lines 58322 58465 +143
==========================================
+ Hits 29773 29959 +186
+ Misses 25598 25555 -43
Partials 2951 2951
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/cherry-pick release-1.0 |
|
🤖 says: Error cherry-picking. |
|
🤖 says: |
part of #9518, without introducing a new naming policy for serviceaccount.