Change metric to use CS for search. Also order by distance. #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsaluja9
requested review from
ali-asadpoor,
bovlb,
drewaogle,
luisremis and
vishakha041
bovlb
approved these changes
Jul 16, 2025
| " },\n", | ||
| " \"results\": {\n", | ||
| " \"all_properties\": True # Return all properties\n", | ||
| " \"list\": [\"_uniqueid\"], # Return all properties\n", |
Contributor
There was a problem hiding this comment.
Suggested change
| " \"list\": [\"_uniqueid\"], # Return all properties\n", | |
| " \"list\": [\"_uniqueid\"], # Return only unique ids\n", |
| "# Check if the query was successful\n", | ||
| "if result == 0:\n", | ||
| " display(blobs)\n" | ||
| " #Here we reorder the images based on the distances before displaying them\n", |
Contributor
There was a problem hiding this comment.
Suggested change
| " #Here we reorder the images based on the distances before displaying them\n", | |
| " # Here we reorder the images based on the distances before displaying them\n", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here it's also observed that a more precise query "a photo of bread on a plate" yields better matches than "a photo of bread"