-
Notifications
You must be signed in to change notification settings - Fork 0
basic functionality for adding width and height to images #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds basic functionality for adding width and height properties to images that lack these attributes. The implementation includes a new workflow service that processes images in batches, extracts their dimensions using PIL, and updates the database with the width and height information.
- Adds a new Docker service for the add-width-and-height workflow with appropriate environment configuration
- Implements the core Python script that processes images in batches and updates their width/height properties
- Sets up the necessary Docker infrastructure and CI/CD integration for the new workflow
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| docker-compose.yml | Adds service definition for the add-width-and-height workflow |
| base/docker/scripts/add_width_and_height_to_images.py | Core implementation that processes images and adds width/height properties |
| base/docker/Dockerfile | Copies the Python script to the base Docker image |
| apps/add-width-and-height/requirements.txt | Defines Pillow dependency for image processing |
| apps/add-width-and-height/app/app.sh | Shell script that runs the workflow in a loop with status updates |
| apps/add-width-and-height/README.md | Documentation for the new workflow |
| apps/add-width-and-height/Dockerfile | Docker configuration for the workflow service |
| .github/workflows/main.yml | Adds the new service to CI/CD pipeline |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This workflow looks for images that lack the
widthandheightproperties and adds them.While I packaged this as an independent workflow, the core implementation is a single module in the workflow base, so it could also be incorporated into another workflow without difficulty.