Open
Conversation
Otherwise, in my experience, you just spam click and don't really know it worked
Author
|
Noticed @tehchives has a fork implementation, but I'm not sure if it's his or yours that's live right now. Could be good to move into @WhyDRS org if it's something extendable or reusable? |
|
The inbuilt call to email is a great idea John, if we can get it to work! I was banging my head on this one hah. Wix button implementation was making it difficult, and the outside widget wasn't properly accessing the clipboard from an iframe, but if we are commiting to the outside page we can move past those problems. I do not believe my fork ever ended up being used - That was something I did to play around and try to get Throw's code to conform to some of those ideas. My impression is that the page currently feeds directly to his original. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stellar job getting this done so quickly for the upcoming letter submission. We're sure to get our rulemaking goals on the agenda with your petition automation! 👏 Just a few smalls things I noticed when testing in Brave:
The first observation was fixed by employing
preventDefault()- the second with a clipboard alert popup. I'll leave it up to everyone to figure out if we want to join the copying function with an inbuilt call to email such as: