Skip to content

🪲 Minor user experience fixes#1

Open
JFWooten4 wants to merge 3 commits intoapes-on-parade:mainfrom
JFWooten4:patch-1
Open

🪲 Minor user experience fixes#1
JFWooten4 wants to merge 3 commits intoapes-on-parade:mainfrom
JFWooten4:patch-1

Conversation

@JFWooten4
Copy link

Stellar job getting this done so quickly for the upcoming letter submission. We're sure to get our rulemaking goals on the agenda with your petition automation! 👏 Just a few smalls things I noticed when testing in Brave:

  • Clicking copy copies the text and opens a new blank tab with just the widget
  • No way for the user to know their text was copied without manually pasting
  • User still needs to click to open their email client after copying info

The first observation was fixed by employing preventDefault() - the second with a clipboard alert popup. I'll leave it up to everyone to figure out if we want to join the copying function with an inbuilt call to email such as:

// [copy to clipboard alert]
window.location.href = "mailto:Secretarys-Office@SEC.GOV?subject=Petition%20for%20Rulemaking%3A%20Amend%20Clearing%20Agency%20Rules%20for%20Consistent%20Close%20Outs"

JFWooten4 and others added 3 commits September 1, 2024 18:05
Otherwise, in my experience, you just spam click and don't really know it worked
@JFWooten4
Copy link
Author

JFWooten4 commented Sep 8, 2024

Noticed @tehchives has a fork implementation, but I'm not sure if it's his or yours that's live right now.

Could be good to move into @WhyDRS org if it's something extendable or reusable?

@tehchives
Copy link

The inbuilt call to email is a great idea John, if we can get it to work! I was banging my head on this one hah. Wix button implementation was making it difficult, and the outside widget wasn't properly accessing the clipboard from an iframe, but if we are commiting to the outside page we can move past those problems.

I do not believe my fork ever ended up being used - That was something I did to play around and try to get Throw's code to conform to some of those ideas. My impression is that the page currently feeds directly to his original.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants