Changing test to not use Order object #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveespo
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Thanks -- finding a set of standard object that's available regardless of flavor/generation/type of org is like walking a mine field. I have no affinity to the Order object so we can give ListEmails a try instead.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @daveerickson)
|
Yeah, I was walking describe info for Opportunity to find List Email. :) Thanks for being flexible, and for the quick response. |
ImJohnMDaniel
approved these changes
Feb 18, 2025
ImJohnMDaniel
merged commit b22fa15
into
apex-enterprise-patterns:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also ran into the issue identified in #505 within my project since my org does not have Orders enabled.
I changed Order object to List Email since that seems to be one of few that do not need to be enabled and has Activities enabled. I am open to refactoring to a different object if List Email is not preferred.
This change is