chore: cleanup phpstan (#4865)

Author: dannyvw

phpstan.neon.dist

@@ -19,15 +19,8 @@ parameters:
 		# Symfony cache
 		- tests/Fixtures/app/var/
 		- tests/Fixtures/Symfony/Maker
-		# BC layer
-		- src/deprecated_interfaces.php
-		- tests/Fixtures/TestBundle/BrowserKit/Client.php
 		# The Symfony Configuration API isn't good enough to be analysed
 		- src/Symfony/Bundle/DependencyInjection/Configuration.php
-		# Phpstan runs on phpunit > 9, a signature changed in this file
-		- src/Symfony/Bundle/Test/Constraint/ArraySubsetLegacy.php
-		# Imported code (temporary)
-		- src/Symfony/Bundle/Test/BrowserKitAssertionsTrait.php
 		# Templates for Maker
 		- src/Symfony/Maker/Resources/skeleton
 	earlyTerminatingMethodCalls:

tests/Fixtures/TestBundle/BrowserKit/Client.php

@@ -13,48 +13,25 @@
 
 namespace ApiPlatform\Tests\Fixtures\TestBundle\BrowserKit;
 
-use Symfony\Bundle\FrameworkBundle\Client as BaseClient;
 use Symfony\Bundle\FrameworkBundle\KernelBrowser;
-use Symfony\Component\BrowserKit\AbstractBrowser;
 use Symfony\Component\BrowserKit\Request as DomRequest;
 use Symfony\Component\HttpFoundation\Request;
 
-if (class_exists(AbstractBrowser::class)) {
-    class Client extends KernelBrowser
+class Client extends KernelBrowser
+{
+    /**
+     * {@inheritdoc}
+     */
+    protected function filterRequest(DomRequest $request): Request
     {
-        /**
-         * {@inheritdoc}
-         */
-        protected function filterRequest(DomRequest $request): Request
-        {
-            $request = parent::filterRequest($request);
+        $request = parent::filterRequest($request);
 
-            foreach ($request->headers->all() as $key => $value) {
-                if ([null] === $value) {
-                    $request->headers->remove($key);
-                }
+        foreach ($request->headers->all() as $key => $value) {
+            if ([null] === $value) {
+                $request->headers->remove($key);
             }
-
-            return $request;
         }
-    }
-} else {
-    class Client extends BaseClient
-    {
-        /**
-         * {@inheritdoc}
-         */
-        protected function filterRequest(DomRequest $request): Request
-        {
-            $request = parent::filterRequest($request);
 
-            foreach ($request->headers->all() as $key => $value) {
-                if ([null] === $value) {
-                    $request->headers->remove($key);
-                }
-            }
-
-            return $request;
-        }
+        return $request;
     }
 }