Skip to content

Commit c4f0ef1

Browse files
committed
Fix phpstan v0.11.5 false positives
1 parent 6e9014e commit c4f0ef1

File tree

4 files changed

+21
-13
lines changed

4 files changed

+21
-13
lines changed

phpstan.neon.dist

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,6 @@ parameters:
3232
-
3333
message: '#Cannot assign offset .+ to bool\.#'
3434
path: %currentWorkingDirectory%/src/GraphQl/Resolver/FieldsToAttributesTrait.php
35-
-
36-
message: '#Access to an undefined property GraphQL\\Language\\AST\\ValueNode::\$value\.#'
37-
path: %currentWorkingDirectory%/src/GraphQl/Type/Definition/IterableType.php
3835
- '#Access to an undefined property Prophecy\\Prophecy\\ObjectProphecy<(\\?[a-zA-Z0-9_]+)+>::\$[a-zA-Z0-9_]+#'
3936
- '#Call to an undefined method Doctrine\\Common\\Persistence\\ObjectManager::getConnection\(\)#'
4037
- '#Parameter \#1 \$function of function call_user_func expects callable\(\): mixed, .+ given\.#'
@@ -56,6 +53,15 @@ parameters:
5653
-
5754
message: '#Parameter \#1 \$collection of method ApiPlatform\\Core\\Tests\\GraphQl\\Resolver\\Factory\\CollectionResolverFactoryTest::createCollectionResolverFactory\(\) expects array\|Iterator, object given\.#'
5855
path: %currentWorkingDirectory%/tests/GraphQl/Resolver/Factory/CollectionResolverFactoryTest.php
56+
-
57+
message: '#Parameter \#1 \$resourceClass of method ApiPlatform\\Core\\Metadata\\Property\\Factory\\InheritedPropertyMetadataFactory::create\(\) expects string, object\|string given\.#'
58+
path: %currentWorkingDirectory%/src/Metadata/Property/Factory/InheritedPropertyMetadataFactory.php
59+
-
60+
message: '#Parameter \#1 \$childInherited of method ApiPlatform\\Core\\Metadata\\Property\\PropertyMetadata::withChildInherited\(\) expects string, object\|string given\.#'
61+
path: %currentWorkingDirectory%/src/Metadata/Property/Factory/InheritedPropertyMetadataFactory.php
62+
-
63+
message: '#Parameter \#1 \$resourceClass of method ApiPlatform\\Core\\Metadata\\Property\\Factory\\InheritedPropertyNameCollectionFactory::create\(\) expects string, object\|string given\.#'
64+
path: %currentWorkingDirectory%/src/Metadata/Property/Factory/InheritedPropertyNameCollectionFactory.php
5965
-
6066
message: '#Property ApiPlatform\\Core\\Test\\DoctrineMongoDbOdmFilterTestCase::\$repository \(Doctrine\\ODM\\MongoDB\\Repository\\DocumentRepository\) does not accept Doctrine\\ORM\\EntityRepository<ApiPlatform\\Core\\Tests\\Fixtures\\TestBundle\\Document\\Dummy>\.#'
6167
path: %currentWorkingDirectory%/src/Test/DoctrineMongoDbOdmFilterTestCase.php

src/Metadata/Property/Factory/InheritedPropertyMetadataFactory.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@
2323
*/
2424
final class InheritedPropertyMetadataFactory implements PropertyMetadataFactoryInterface
2525
{
26-
private $resourceNameCollection;
26+
private $resourceNameCollectionFactory;
2727
private $decorated;
2828

29-
public function __construct(ResourceNameCollectionFactoryInterface $resourceNameCollection, PropertyMetadataFactoryInterface $decorated = null)
29+
public function __construct(ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory, PropertyMetadataFactoryInterface $decorated = null)
3030
{
31-
$this->resourceNameCollection = $resourceNameCollection;
31+
$this->resourceNameCollectionFactory = $resourceNameCollectionFactory;
3232
$this->decorated = $decorated;
3333
}
3434

@@ -39,7 +39,7 @@ public function create(string $resourceClass, string $property, array $options =
3939
{
4040
$propertyMetadata = $this->decorated ? $this->decorated->create($resourceClass, $property, $options) : new PropertyMetadata();
4141

42-
foreach ($this->resourceNameCollection->create() as $knownResourceClass) {
42+
foreach ($this->resourceNameCollectionFactory->create() as $knownResourceClass) {
4343
if ($resourceClass === $knownResourceClass) {
4444
continue;
4545
}

src/Metadata/Property/Factory/InheritedPropertyNameCollectionFactory.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@
2323
*/
2424
final class InheritedPropertyNameCollectionFactory implements PropertyNameCollectionFactoryInterface
2525
{
26-
private $resourceNameCollection;
26+
private $resourceNameCollectionFactory;
2727
private $decorated;
2828

29-
public function __construct(ResourceNameCollectionFactoryInterface $resourceNameCollection, PropertyNameCollectionFactoryInterface $decorated = null)
29+
public function __construct(ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory, PropertyNameCollectionFactoryInterface $decorated = null)
3030
{
31-
$this->resourceNameCollection = $resourceNameCollection;
31+
$this->resourceNameCollectionFactory = $resourceNameCollectionFactory;
3232
$this->decorated = $decorated;
3333
}
3434

@@ -46,7 +46,7 @@ public function create(string $resourceClass, array $options = []): PropertyName
4646
}
4747
}
4848

49-
foreach ($this->resourceNameCollection->create() as $knownResourceClass) {
49+
foreach ($this->resourceNameCollectionFactory->create() as $knownResourceClass) {
5050
if ($resourceClass === $knownResourceClass) {
5151
continue;
5252
}

src/Metadata/Resource/ResourceNameCollection.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,18 @@ public function __construct(array $classes = [])
3232

3333
/**
3434
* {@inheritdoc}
35+
*
36+
* @return \Traversable<string>
3537
*/
36-
public function getIterator()
38+
public function getIterator(): \Traversable
3739
{
3840
return new \ArrayIterator($this->classes);
3941
}
4042

4143
/**
4244
* {@inheritdoc}
4345
*/
44-
public function count()
46+
public function count(): int
4547
{
4648
return \count($this->classes);
4749
}

0 commit comments

Comments
 (0)