fix(doctrine): throw an exception when a filter is not found in a parameter #6767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
force-pushed
the
dx-exception-on-invalid-filter
branch
2 times, most recently
from
9ca6057 to
f20ac7a
Compare
soyuka
reviewed
Nov 4, 2024
| if ($filter instanceof FilterInterface) { | ||
| $filter->apply($queryBuilder, $queryNameGenerator, $resourceClass, $operation, ['filters' => $values, 'parameter' => $parameter] + $context); | ||
| if (!$filter instanceof FilterInterface) { | ||
| throw new \InvalidArgumentException(\sprintf('Could not find filter "%s" for parameter "%s" in operation "%s" for resource "%s".', $filterId, $parameter->getKey(), $operation?->getShortName(), $resourceClass)); |
Member
There was a problem hiding this comment.
Can the exception be from ApiPlatform\Metadata\Exception please?
lyrixx
force-pushed
the
dx-exception-on-invalid-filter
branch
from
f20ac7a to
dfac68c
Compare
soyuka
force-pushed
the
dx-exception-on-invalid-filter
branch
from
dfac68c to
667d779
Compare
soyuka
changed the title
Member
|
I think that we should fix that inside Doctrine ODM as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there are many places where APIP fails silently. This make our code harder to debug.
I don't know if this is a feature, or just a mistake. If it's a mistake, I'll try to send more PR.