Skip to content

fix(state): empty result when the array paginator is out of bound #6785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soyuka merged 1 commit into from
Nov 14, 2024
Merged

fix(state): empty result when the array paginator is out of bound #6785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/State/Pagination/ArrayPaginator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,15 @@ final class ArrayPaginator implements \IteratorAggregate, PaginatorInterface, Ha

public function __construct(array $results, int $firstResult, int $maxResults)
{
if ($maxResults > 0) {
$this->firstResult = $firstResult;
$this->maxResults = $maxResults;
$this->totalItems = \count($results);

if ($maxResults > 0 && $firstResult < $this->totalItems) {
$this->iterator = new \LimitIterator(new \ArrayIterator($results), $firstResult, $maxResults);
} else {
$this->iterator = new \EmptyIterator();
}
$this->firstResult = $firstResult;
$this->maxResults = $maxResults;
$this->totalItems = \count($results);
}

/**
Expand Down
1 change: 1 addition & 0 deletions tests/State/Pagination/ArrayPaginatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public static function initializeProvider(): array
'Second of two pages of 3 items for the first page and 2 for the second' => [[0, 1, 2, 3, 4], 3, 3, 2, 5, 2, 2, false],
'Empty results' => [[], 0, 2, 0, 0, 1, 1, false],
'0 for max results' => [[0, 1, 2, 3], 2, 0, 0, 4, 1, 1, false],
'First result greater than total items' => [[0, 1], 2, 1, 0, 2, 3, 2, false],
];
}
}
Loading