fix(jsonschema): hashmaps produces invalid openapi schema #6830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
soyuka
reviewed
Nov 27, 2024
soyuka
reviewed
Nov 27, 2024
src/JsonSchema/Metadata/Property/Factory/SchemaPropertyMetadataFactory.php
Outdated
Show resolved
Hide resolved
Member
|
@ostrolucky can you confirm this fixes your issue? |
vinceAmstoutz
force-pushed
the
fix-openapi-schema-hashmaps-array-phpdoc-objects
branch
from
5bba1f8 to
520c232
Compare
Contributor
|
Not quite complete. Although it no longer does "additionalProperties": {
"type": "unknown_type"
}instead of expected "additionalProperties": {
"type": "object",
"properties": {"name": {"type": "string"}}
}it's doing "additionalProperties": {
"type": "string"
}In swagger-ui it makes a difference between |
soyuka
reviewed
Nov 28, 2024
src/JsonSchema/Metadata/Property/Factory/SchemaPropertyMetadataFactory.php
Outdated
Show resolved
Hide resolved
vinceAmstoutz
force-pushed
the
fix-openapi-schema-hashmaps-array-phpdoc-objects
branch
from
520c232 to
6119f8d
Compare
Member
Author
|
@ostrolucky Can you please do another test? It looks like this now |
vinceAmstoutz
force-pushed
the
fix-openapi-schema-hashmaps-array-phpdoc-objects
branch
from
6119f8d to
06d6227
Compare
Contributor
|
I'm getting infinite loop now |
Member
|
You have self referencing objects? This means that we need to track DTOs and actually create refs? |
soyuka
reviewed
Nov 29, 2024
src/JsonSchema/Metadata/Property/Factory/SchemaPropertyMetadataFactory.php
Outdated
Show resolved
Hide resolved
soyuka
force-pushed
the
fix-openapi-schema-hashmaps-array-phpdoc-objects
branch
from
102c231 to
2e3fc91
Compare
Member
|
I've come up with a fix, the first iteration wasn't good actually this almost worked we forgot to handle the |
vinceAmstoutz
deleted the
fix-openapi-schema-hashmaps-array-phpdoc-objects
branch
soyuka
added a commit
that referenced
this pull request
Dec 13, 2024
* fix(jsonschema): hashmaps produces invalid openapi schema (#6830) * fix(jsonschema): hashmaps produces invalid openapi schema * fix --------- Co-authored-by: soyuka <[email protected]> * fix: add missing error normalizer trait and remove deprecated interface (#6853) * fix: test empty parameter against null (#6852) fixes #6844 * Fix deprecation symfony/dependency-injection * cs: run php-cs-fixer * ci: use problem error normalizer trait * fix(metadata): various parameter improvements (#6867) - `Parameter::getValue()` now takes a default value as argument `getValue(mixed $default = new ParameterNotFound()): mixed` - `Parametes::get(string $key, string $parameterClass = QueryParameter::class)` (but also `has` and `remove`) now has a default value as second argument to `QueryParameter::class` - Constraint violation had the wrong message when using `property`, fixed by using the `key` instead: --------- Co-authored-by: Vincent Amstoutz <[email protected]> Co-authored-by: mladencosa <[email protected]> Co-authored-by: Michiel Kalle <[email protected]>
vinceAmstoutz
added a commit
to vinceAmstoutz/api-platform-core
that referenced
this pull request
Dec 24, 2024
…rm#6830) * fix(jsonschema): hashmaps produces invalid openapi schema * fix --------- Co-authored-by: soyuka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.4Key changes: