chore: solve some phpstan issues

phpstan.neon.dist

@@ -105,11 +105,6 @@ parameters:
 		    identifier: function.alreadyNarrowedType
 		-
 		    identifier: property.unusedType
-		-
-		    identifier: return.unusedType
-		-
-		    path: tests/
-		    identifier: void.pure
 		-
 		    identifier: varTag.nativeType
 		-

src/Doctrine/Odm/Filter/DateFilter.php

@@ -251,7 +251,7 @@ public function getSchema(Parameter $parameter): array
         return ['type' => 'string', 'format' => 'date'];
     }
 
-    public function getOpenApiParameters(Parameter $parameter): OpenApiParameter|array|null
+    public function getOpenApiParameters(Parameter $parameter): array
     {
         $in = $parameter instanceof QueryParameter ? 'query' : 'header';
         $key = $parameter->getKey();

src/Doctrine/Odm/Filter/RangeFilter.php

@@ -209,7 +209,7 @@
         }
     }
 
-    public function getOpenApiParameters(Parameter $parameter): OpenApiParameter|array|null
+    public function getOpenApiParameters(Parameter $parameter): array
     {
         $in = $parameter instanceof QueryParameter ? 'query' : 'header';
         $key = $parameter->getKey();

src/Doctrine/Orm/Filter/DateFilter.php

@@ -283,7 +283,7 @@ public function getSchema(Parameter $parameter): array
         return ['type' => 'string', 'format' => 'date'];
     }
 
-    public function getOpenApiParameters(Parameter $parameter): OpenApiParameter|array|null
+    public function getOpenApiParameters(Parameter $parameter): array
     {
         $in = $parameter instanceof QueryParameter ? 'query' : 'header';
         $key = $parameter->getKey();

src/Doctrine/Orm/Filter/RangeFilter.php

@@ -227,7 +227,7 @@
         }
     }
 
-    public function getOpenApiParameters(Parameter $parameter): OpenApiParameter|array|null
+    public function getOpenApiParameters(Parameter $parameter): array
     {
         $in = $parameter instanceof QueryParameter ? 'query' : 'header';
         $key = $parameter->getKey();

src/GraphQl/Metadata/RuntimeOperationMetadataFactory.php

@@ -30,7 +30,7 @@ public function __construct(private readonly ResourceMetadataCollectionFactoryIn
     {
     }
 
-    public function create(string $uriTemplate, array $context = []): ?Operation
+    public function create(string $uriTemplate, array $context = []): Operation
     {
         try {
             $parameters = $this->router->match($uriTemplate);

src/GraphQl/Serializer/ObjectNormalizer.php

@@ -53,7 +53,7 @@
      *
      * @throws UnexpectedValueException
      */
-    public function normalize(mixed $object, ?string $format = null, array $context = []): array|string|int|float|bool|\ArrayObject|null
+    public function normalize(mixed $object, ?string $format = null, array $context = []): array
     {
         if (isset($context['api_resource'])) {
             $originalResource = $context['api_resource'];

src/GraphQl/Type/TypeConverter.php

@@ -119,7 +119,7 @@
     /**
      * {@inheritdoc}
      */
-    public function resolveType(string $type): ?GraphQLType
+    public function resolveType(string $type): GraphQLType
     {
         try {
             $astTypeNode = Parser::parseType($type);

src/Hydra/Serializer/DocumentationNormalizer.php

@@ -67,7 +67,7 @@ public function __construct(
     /**
      * {@inheritdoc}
      */
-    public function normalize(mixed $object, ?string $format = null, array $context = []): array|string|int|float|bool|\ArrayObject|null
+    public function normalize(mixed $object, ?string $format = null, array $context = []): array
     {
         $classes = [];
         $entrypointProperties = [];

src/JsonApi/Filter/SparseFieldset.php

@@ -33,7 +33,7 @@
         ];
     }
 
-    public function getOpenApiParameters(MetadataParameter $parameter): Parameter|array|null
+    public function getOpenApiParameters(MetadataParameter $parameter): Parameter
     {
         return new Parameter(
             name: ($k = $parameter->getKey()).'[]',

src/JsonApi/Serializer/EntrypointNormalizer.php

@@ -39,7 +39,7 @@
     /**
      * {@inheritdoc}
      */
-    public function normalize(mixed $object, ?string $format = null, array $context = []): array|string|int|float|bool|\ArrayObject|null
+    public function normalize(mixed $object, ?string $format = null, array $context = []): array
     {
         $entrypoint = ['links' => ['self' => $this->urlGenerator->generate('api_entrypoint', [], UrlGeneratorInterface::ABS_URL)]];
 

src/JsonSchema/Metadata/Property/Factory/SchemaPropertyMetadataFactory.php

@@ -62,7 +62,7 @@ public function create(string $resourceClass, string $property, array $options =
             }
         }
 
-        $extraProperties = $propertyMetadata->getExtraProperties() ?? [];
+        $extraProperties = $propertyMetadata->getExtraProperties();
         // see AttributePropertyMetadataFactory
         if (true === ($extraProperties[self::JSON_SCHEMA_USER_DEFINED] ?? false)) {
             // schema seems to have been declared by the user: do not override nor complete user value

src/JsonSchema/SchemaFactory.php

@@ -176,7 +176,7 @@
             unset($propertySchema['type']);
         }
 
-        $extraProperties = $propertyMetadata->getExtraProperties() ?? [];
+        $extraProperties = $propertyMetadata->getExtraProperties();
         // see AttributePropertyMetadataFactory
         if (true === ($extraProperties[SchemaPropertyMetadataFactory::JSON_SCHEMA_USER_DEFINED] ?? false)) {
             // schema seems to have been declared by the user: do not override nor complete user value
@@ -295,7 +295,7 @@
             $additionalPropertySchema ?? []
         );
 
-        $extraProperties = $propertyMetadata->getExtraProperties() ?? [];
+        $extraProperties = $propertyMetadata->getExtraProperties();
         // see AttributePropertyMetadataFactory
         if (true === ($extraProperties[SchemaPropertyMetadataFactory::JSON_SCHEMA_USER_DEFINED] ?? false)) {
             // schema seems to have been declared by the user: do not override nor complete user value

src/Laravel/Eloquent/Metadata/Factory/Property/EloquentAttributePropertyMetadataFactory.php

@@ -79,7 +79,7 @@
         // can't know later if the schema has been defined by the user or by API Platform
         // store extra key to make this difference
         if (null !== $propertyMetadata->getSchema()) {
-            $extraProperties = $propertyMetadata->getExtraProperties() ?? [];
+            $extraProperties = $propertyMetadata->getExtraProperties();
             $propertyMetadata = $propertyMetadata->withExtraProperties([SchemaPropertyMetadataFactory::JSON_SCHEMA_USER_DEFINED => true] + $extraProperties);
         }
 

src/Metadata/ApiProperty.php

@@ -572,7 +572,7 @@ public function isInitializable(): ?bool
         return $this->initializable;
     }
 
-    public function getExtraProperties(): ?array
+    public function getExtraProperties(): array
     {
         return $this->extraProperties;
     }

src/Metadata/Property/Factory/AttributePropertyMetadataFactory.php

@@ -150,7 +150,7 @@ private function handleUserDefinedSchema(ApiProperty $propertyMetadata): ApiProp
         // can't know later if the schema has been defined by the user or by API Platform
         // store extra key to make this difference
         if (null !== $propertyMetadata->getSchema()) {
-            $extraProperties = $propertyMetadata->getExtraProperties() ?? [];
+            $extraProperties = $propertyMetadata->getExtraProperties();
             $propertyMetadata = $propertyMetadata->withExtraProperties([SchemaPropertyMetadataFactory::JSON_SCHEMA_USER_DEFINED => true] + $extraProperties);
         }
 

src/Metadata/Property/Factory/ExtractorPropertyMetadataFactory.php

@@ -133,7 +133,7 @@
         // can't know later if the schema has been defined by the user or by API Platform
         // store extra key to make this difference
         if (null !== $propertyMetadata->getSchema()) {
-            $extraProperties = $propertyMetadata->getExtraProperties() ?? [];
+            $extraProperties = $propertyMetadata->getExtraProperties();
             $propertyMetadata = $propertyMetadata->withExtraProperties([SchemaPropertyMetadataFactory::JSON_SCHEMA_USER_DEFINED => true] + $extraProperties);
         }
 

src/OpenApi/Serializer/ApiGatewayNormalizer.php

@@ -42,7 +42,7 @@ public function __construct(private readonly NormalizerInterface $documentationN
      *
      * @throws UnexpectedValueException
      */
-    public function normalize(mixed $object, ?string $format = null, array $context = []): array|string|int|float|bool|\ArrayObject|null
+    public function normalize(mixed $object, ?string $format = null, array $context = []): array
     {
         $data = $this->documentationNormalizer->normalize($object, $format, $context);
         if (!\is_array($data)) {

src/Serializer/AbstractItemNormalizer.php

@@ -275,7 +275,7 @@ public function denormalize(mixed $data, string $class, ?string $format = null,
         foreach (array_keys($data) as $attribute) {
             $attribute = $this->nameConverter ? $this->nameConverter->denormalize((string) $attribute) : $attribute;
             $propertyMetadata = $this->propertyMetadataFactory->create($resourceClass, $attribute, $options);
-            $attributeExtraProperties = $propertyMetadata->getExtraProperties() ?? [];
+            $attributeExtraProperties = $propertyMetadata->getExtraProperties();
             $throwOnPropertyAccessDenied = $attributeExtraProperties['throw_on_access_denied'] ?? $throwOnAccessDenied;
             if (!\in_array($attribute, $propertyNames, true)) {
                 continue;

src/Serializer/Filter/PropertyFilter.php

@@ -277,7 +277,7 @@ public function getSchema(MetadataParameter $parameter): array
         ];
     }
 
-    public function getOpenApiParameters(MetadataParameter $parameter): Parameter|array|null
+    public function getOpenApiParameters(MetadataParameter $parameter): Parameter
     {
         $example = \sprintf(
             '%1$s[]={propertyName}&%1$s[]={anotherPropertyName}',

src/State/Exception/ParameterNotSupportedException.php

@@ -33,17 +33,17 @@
         return $this->message;
     }
 
-    public function getStatus(): ?int
+    public function getStatus(): int
     {
         return 400;
     }
 
-    public function getDetail(): ?string
+    public function getDetail(): string
     {
         return \sprintf('Parameter "%s" not supported', $this->parameter);
     }
 
-    public function getInstance(): ?string
+    public function getInstance(): string
     {
         return $this->parameter;
     }

src/State/Provider/BackedEnumProvider.php

@@ -21,7 +21,7 @@
 
 final class BackedEnumProvider implements ProviderInterface
 {
-    public function provide(Operation $operation, array $uriVariables = [], array $context = []): object|array|null
+    public function provide(Operation $operation, array $uriVariables = [], array $context = []): object|array
     {
         $resourceClass = $operation->getClass();
         if (!$resourceClass || !is_a($resourceClass, \BackedEnum::class, true)) {

src/State/Tests/ParameterProviderTest.php

@@ -34,7 +34,7 @@ public function get(string $id)
             {
                 if ('test' === $id) {
                     return new class implements ParameterProviderInterface {
-                        public function provide(Parameter $parameter, array $parameters = [], array $context = []): ?Operation
+                        public function provide(Parameter $parameter, array $parameters = [], array $context = []): Operation
                         {
                             return new Get(name: 'ok');
                         }

src/Symfony/Routing/IriConverter.php

@@ -113,7 +113,7 @@ public function getResourceFromIri(string $iri, array $context = [], ?Operation
     /**
      * {@inheritdoc}
      */
-    public function getIriFromResource(object|string $resource, int $referenceType = UrlGeneratorInterface::ABS_PATH, ?Operation $operation = null, array $context = []): ?string
+    public function getIriFromResource(object|string $resource, int $referenceType = UrlGeneratorInterface::ABS_PATH, ?Operation $operation = null, array $context = []): string
     {
         $resourceClass = $context['force_resource_class'] ?? (\is_string($resource) ? $resource : $this->getObjectClass($resource));
 

src/Symfony/Routing/SkolemIriConverter.php

@@ -49,7 +49,7 @@ public function getResourceFromIri(string $iri, array $context = [], ?Operation
     /**
      * {@inheritdoc}
      */
-    public function getIriFromResource(object|string $resource, int $referenceType = UrlGeneratorInterface::ABS_PATH, ?Operation $operation = null, array $context = []): ?string
+    public function getIriFromResource(object|string $resource, int $referenceType = UrlGeneratorInterface::ABS_PATH, ?Operation $operation = null, array $context = []): string
     {
         $referenceType = $operation ? ($operation->getUrlGenerationStrategy() ?? $referenceType) : $referenceType;
         if (($isObject = \is_object($resource)) && $this->objectHashMap->contains($resource)) {

src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaCollectionRestriction.php

@@ -76,7 +76,7 @@
 
         foreach ($nestedConstraints as $nestedConstraint) {
             foreach ($this->restrictionsMetadata as $restrictionMetadata) {
-                if ($restrictionMetadata->supports($nestedConstraint, $propertyMetadata->withExtraProperties(($propertyMetadata->getExtraProperties() ?? []) + ['nested_schema' => true])) && !empty($nestedConstraintRestriction = $restrictionMetadata->create($nestedConstraint, $propertyMetadata))) {
+                if ($restrictionMetadata->supports($nestedConstraint, $propertyMetadata->withExtraProperties($propertyMetadata->getExtraProperties() + ['nested_schema' => true])) && !empty($nestedConstraintRestriction = $restrictionMetadata->create($nestedConstraint, $propertyMetadata))) {
                     $propertyRestrictions[] = $nestedConstraintRestriction;
                 }
             }

src/Symfony/Validator/Metadata/Property/ValidatorPropertyMetadataFactory.php

@@ -94,7 +94,7 @@ public function create(string $resourceClass, string $property, array $options =
     {
         $propertyMetadata = $this->decorated->create($resourceClass, $property, $options);
 
-        $extraProperties = $propertyMetadata->getExtraProperties() ?? [];
+        $extraProperties = $propertyMetadata->getExtraProperties();
         // see AttributePropertyMetadataFactory
         if (true === ($extraProperties[SchemaPropertyMetadataFactory::JSON_SCHEMA_USER_DEFINED] ?? false)) {
             // schema seems to have been declared by the user: do not override nor complete user value

tests/Fixtures/TestBundle/HttpCache/TagCollectorCustom.php

@@ -69,7 +69,7 @@ public function collect(array $context = []): void
         $this->addCacheTagForResource($context, $iri);
     }
 
-    private function addCacheTagForResource(array $context, string $iri): void
+    private function addCacheTagForResource(array &$context, string $iri): void
     {
         $context['resources'][$iri] = $iri;
     }

tests/Fixtures/TestBundle/HttpCache/TagCollectorDefault.php

@@ -29,7 +29,7 @@ public function collect(array $context = []): void
         }
     }
 
-    private function addResourceToContext(array $context): void
+    private function addResourceToContext(array &$context): void
     {
         $iri = $context['iri'];
 

tests/Fixtures/TestBundle/Serializer/ErrorNormalizer.php

@@ -22,7 +22,7 @@ public function __construct(private readonly NormalizerInterface $decorated)
     {
     }
 
-    public function normalize(mixed $object, ?string $format = null, array $context = []): array|string|int|float|bool|\ArrayObject
+    public function normalize(mixed $object, ?string $format = null, array $context = []): array|\ArrayObject
     {
         $a = $this->decorated->normalize($object, $format, $context);
         $a['hello'] = 'world';

tests/Fixtures/TestBundle/Serializer/Normalizer/OverrideDocumentationNormalizer.php

@@ -31,7 +31,7 @@ public function __construct(private readonly NormalizerInterface $documentationN
      *
      * @throws ExceptionInterface
      */
-    public function normalize($object, $format = null, array $context = []): \ArrayObject|array|string|int|float|bool|null
+    public function normalize($object, $format = null, array $context = []): array
     {
         $data = $this->documentationNormalizer->normalize($object, $format, $context);
         if (!\is_array($data)) {