Skip to content

fix(symfony): do not load docs routes if docs disabled #7448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 4.2
Choose a base branch
from
+4 −1
Open

fix(symfony): do not load docs routes if docs disabled #7448

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90f4ca7
feature/do-not-load-docs-routes-if-docs-disabled
alexndlm Oct 8, 2025
7ff2c24
-refactoring
alexndlm Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Symfony/Routing/ApiLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,10 @@ public function supports(mixed $resource, ?string $type = null): bool
*/
private function loadExternalFiles(RouteCollection $routeCollection): void
{
$routeCollection->addCollection($this->fileLoader->load('docs.xml'));
if ($this->docsEnabled) {
$routeCollection->addCollection($this->fileLoader->load('docs.xml'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GromNaN should we also move our routes to php?

Copy link
Contributor

@GromNaN GromNaN Oct 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it need to be done also: symfony/symfony#60568
We should add a 2nd transformation class in https://github.com/GromNaN/symfony-config-xml-to-php

}

$routeCollection->addCollection($this->fileLoader->load('genid.xml'));
$routeCollection->addCollection($this->fileLoader->load('errors.xml'));

Expand Down
Loading