Check coverage #7666
Closed
Check coverage #7666
+0
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
VincentLanglet
commented
Jan 9, 2026
VincentLanglet
commented
| Q | A |
|---|---|
| Branch? | main for features / current stable version branch for bug fixes |
| Tickets | Closes #..., closes #... |
| License | MIT |
| Doc PR | api-platform/docs#... |
soyuka
reviewed
Jan 12, 2026
| if ($this->isPropertyNested($property, $resourceClass)) { | ||
| [$alias, $field, $associations] = $this->addJoinsForNestedProperty($property, $alias, $queryBuilder, $queryNameGenerator, $resourceClass, Join::INNER_JOIN); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Yes, that's what I tried to explain in #7628 (comment)
- I'm not sure it fully works (expecially with the nameConverter issues)
- It's not tested since no test fail when I remove this code
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.