Skip to content

Conversation

@noweh
Copy link
Contributor

@noweh noweh commented Oct 12, 2024

  • Added missing 'use' statements in the laravel/index.md for clarity
  • Fixed a typo in a Model usage
  • Corrected 'ProviderInterface::class' to 'provider' in ApiServiceProvider

Solves api-platform/core#6717

- Added missing 'use' statements in the laravel/index.md for clarity
- Fixed a typo in a Model usage
- Corrected 'ProviderInterface::class' to 'provider' in ApiServiceProvider
Change 'provider' to ProviderInterface::class in laravel/index.md
Fix some docs about DTO
@noweh
Copy link
Contributor Author

noweh commented Oct 14, 2024

This PR fix this issue : api-platform/core#6717

Use the constructor property promotion syntax in ApiResource/Book
Copy link
Member

@vinceAmstoutz vinceAmstoutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @soyuka could you take a look please?

@vinceAmstoutz
Copy link
Member

Can you please rebase @noweh? I'll merge it after.

@soyuka soyuka merged commit 2fd0a82 into api-platform:4.0 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants