Parameters documentation improvements #2187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/filters.md
Outdated
| parameters: [ | ||
| 'dummy' => new QueryParameter( | ||
| provider: ReadLinkParameterProvider::class, | ||
| extraProperties: ['resource_class' => Dummy::class] |
There was a problem hiding this comment.
Should it also showcase the extra property uri_template?
core/filters.md
Outdated
| private ?int $id = null; | ||
| public function apply(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void | ||
| { | ||
| $value = $context['parameter']?->getValue(); |
There was a problem hiding this comment.
Should it advocate for $operation->getParameters()->get('myParameter')->getValue(); approach more than through the context?
There was a problem hiding this comment.
Not really imo as the filter receives the parameter it is called on, in the other case you need to find the parameter though a filter may be used on many parameters.
aegypius
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.