Skip to content

feat: support setting loadBalancerClass for gateway service #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nic-chen merged 6 commits into from
Sep 12, 2025
Merged

feat: support setting loadBalancerClass for gateway service #203

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fe639cb
feat: support setting loadBalancerClass for gateway service
nic-chen Sep 12, 2025
0dfc88d
fix: apply comment
nic-chen Sep 12, 2025
960eb57
chore: update version
nic-chen Sep 12, 2025
ddc3ae4
f
nic-chen Sep 12, 2025
16f2618
f
nic-6443 Sep 12, 2025
86d34ee
f
nic-chen Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/gateway/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.2.22
version: 0.2.23

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
appVersion: "3.8.10"
appVersion: "3.8.11"

maintainers:
- name: API7
Expand Down
3 changes: 3 additions & 0 deletions charts/gateway/templates/service-admin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ metadata:
spec:
type: {{ .Values.admin.type }}
{{- if eq .Values.admin.type "LoadBalancer" }}
{{- if .Values.admin.loadBalancerClass }}
loadBalancerClass: {{ .Values.admin.loadBalancerClass }}
{{- end }}
{{- if .Values.admin.loadBalancerIP }}
loadBalancerIP: {{ .Values.admin.loadBalancerIP }}
{{- end }}
Expand Down
3 changes: 3 additions & 0 deletions charts/gateway/templates/service-gateway.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ spec:
externalTrafficPolicy: {{ .Values.gateway.externalTrafficPolicy }}
{{- end }}
{{- if eq .Values.gateway.type "LoadBalancer" }}
{{- if .Values.gateway.loadBalancerClass }}
loadBalancerClass: {{ .Values.gateway.loadBalancerClass }}
{{- end }}
{{- if .Values.gateway.loadBalancerIP }}
loadBalancerIP: {{ .Values.gateway.loadBalancerIP }}
{{- end }}
Expand Down
6 changes: 6 additions & 0 deletions charts/gateway/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,11 @@ gateway:
# ref: https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer/#preserving-the-client-source-ip
externalTrafficPolicy: Cluster
# type: LoadBalancer
# loadBalancerClass: "my-loadbalancer-class"
# loadBalancerIP: a.b.c.d
# loadBalancerSourceRanges:
# - "143.231.0.0/16"
# -- IPs for which nodes in the cluster will also accept traffic for the servic
# annotations:
# service.beta.kubernetes.io/aws-load-balancer-type: nlb
externalIPs: []
Expand Down Expand Up @@ -311,6 +316,7 @@ admin:
enabled: false
# -- admin service type
type: ClusterIP
# loadBalancerClass: "my-loadbalancer-class"
# loadBalancerIP: a.b.c.d
# loadBalancerSourceRanges:
# - "143.231.0.0/16"
Expand Down
Loading