fix: r

Signed-off-by: ashing <[email protected]>

Author: ronething

internal/controller/httproute_controller.go

@@ -170,12 +170,6 @@ func (r *HTTPRouteReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 		}
 	}
 
-	filteredHTTPRoute, err := filterHostnames(gateways, hr.DeepCopy())
-	if err != nil {
-		acceptStatus.status = false
-		acceptStatus.msg = err.Error()
-	}
-
 	var httpRouteErr error
 	if err := r.processHTTPRoute(tctx, hr); err != nil {
 		httpRouteErr = err
@@ -207,17 +201,24 @@ func (r *HTTPRouteReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 	}
 	ProcessBackendTrafficPolicy(r.Client, r.Log, tctx)
 
-	routeToUpdate := hr
-	if err == nil && filteredHTTPRoute != nil {
-		r.Log.Info("filteredHTTPRoute", "filteredHTTPRoute", filteredHTTPRoute)
-		routeToUpdate = filteredHTTPRoute
-	}
-
-	if err := r.Provider.Update(ctx, tctx, routeToUpdate); err != nil {
+	filteredHTTPRoute, err := filterHostnames(gateways, hr.DeepCopy())
+	if err != nil {
 		acceptStatus.status = false
 		acceptStatus.msg = err.Error()
 	}
 
+	if isRouteAccepted(gateways) && err == nil {
+		routeToUpdate := hr
+		if filteredHTTPRoute != nil {
+			r.Log.Info("filteredHTTPRoute", "filteredHTTPRoute", filteredHTTPRoute)
+			routeToUpdate = filteredHTTPRoute
+		}
+		if err := r.Provider.Update(ctx, tctx, routeToUpdate); err != nil {
+			acceptStatus.status = false
+			acceptStatus.msg = err.Error()
+		}
+	}
+
 	// TODO: diff the old and new status
 	hr.Status.Parents = make([]gatewayv1.RouteParentStatus, 0, len(gateways))
 	for _, gateway := range gateways {
@@ -226,9 +227,6 @@ func (r *HTTPRouteReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 		for _, condition := range gateway.Conditions {
 			parentStatus.Conditions = MergeCondition(parentStatus.Conditions, condition)
 		}
-		if gateway.ListenerName == "" {
-			continue
-		}
 		SetRouteConditionAccepted(&parentStatus, hr.GetGeneration(), acceptStatus.status, acceptStatus.msg)
 		SetRouteConditionResolvedRefs(&parentStatus, hr.GetGeneration(), resolveRefStatus.status, resolveRefStatus.msg)
 		hr.Status.Parents = append(hr.Status.Parents, parentStatus)

internal/controller/utils.go

@@ -14,6 +14,7 @@ package controller
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"path"
 	"reflect"
@@ -48,6 +49,10 @@ const (
 
 const defaultIngressClassAnnotation = "ingressclass.kubernetes.io/is-default-class"
 
+var (
+	ErrNoMatchingListenerHostname = errors.New("no matching hostnames in listener")
+)
+
 // IsDefaultIngressClass returns whether an IngressClass is the default IngressClass.
 func IsDefaultIngressClass(obj client.Object) bool {
 	if ingressClass, ok := obj.(*networkingv1.IngressClass); ok {
@@ -229,10 +234,15 @@ func SetRouteConditionAccepted(routeParentStatus *gatewayv1.RouteParentStatus, g
 		conditionStatus = metav1.ConditionFalse
 	}
 
+	reason := gatewayv1.RouteReasonAccepted
+	if message == ErrNoMatchingListenerHostname.Error() {
+		reason = gatewayv1.RouteReasonNoMatchingListenerHostname
+	}
+
 	condition := metav1.Condition{
 		Type:               string(gatewayv1.RouteConditionAccepted),
 		Status:             conditionStatus,
-		Reason:             string(gatewayv1.RouteReasonAccepted),
+		Reason:             string(reason),
 		ObservedGeneration: generation,
 		Message:            message,
 		LastTransitionTime: metav1.Now(),
@@ -926,7 +936,7 @@ func filterHostnames(gateways []RouteParentRefContext, httpRoute *gatewayv1.HTTP
 			}
 		}
 		if len(filteredHostnames) == 0 {
-			return httpRoute, fmt.Errorf("no matching hostnames in listener")
+			return httpRoute, ErrNoMatchingListenerHostname
 		}
 	}
 
@@ -1005,3 +1015,14 @@ func isListenerHostnameEffective(listener gatewayv1.Listener) bool {
 		listener.Protocol == gatewayv1.HTTPSProtocolType ||
 		listener.Protocol == gatewayv1.TLSProtocolType
 }
+
+func isRouteAccepted(gateways []RouteParentRefContext) bool {
+	for _, gateway := range gateways {
+		for _, condition := range gateway.Conditions {
+			if condition.Type == string(gatewayv1.RouteConditionAccepted) && condition.Status == metav1.ConditionTrue {
+				return true
+			}
+		}
+	}
+	return false
+}