Skip to content

Commit c2786f3

Browse files
committed
not having secret is a listener issue
1 parent fec2dcd commit c2786f3

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

internal/controller/gateway_controller.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,6 @@ func (r *GatewayReconciler) processListenerConfig(tctx *translator.TranslateCont
241241
log.Error(err, "failed to get secret", "namespace", ns, "name", string(ref.Name))
242242
SetGatewayListenerConditionProgrammed(gateway, string(listener.Name), false, err.Error())
243243
SetGatewayListenerConditionResolvedRefs(gateway, string(listener.Name), false, err.Error())
244-
terror = err
245244
break
246245
}
247246
log.Info("Setting secret for listener", "listener", listener.Name, "secret", secret.Name, " namespace", ns)

internal/controlplane/translator/gateway.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ func (t *Translator) translateSecret(tctx *TranslateContext, listener gatewayv1.
5151
}
5252
name := listener.TLS.CertificateRefs[0].Name
5353
secret := tctx.Secrets[types.NamespacedName{Namespace: ns, Name: string(ref.Name)}]
54+
if secret == nil {
55+
continue
56+
}
5457
if secret.Data == nil {
5558
log.Error("secret data is nil", "secret", secret)
5659
return nil, fmt.Errorf("no secret data found for %s/%s", ns, name)

0 commit comments

Comments
 (0)