Skip to content

Conversation

@ronething
Copy link
Contributor

  • patch gateway proxy to gateway infrastructure

Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
@github-actions
Copy link
Contributor

conformance test report

apiVersion: gateway.networking.k8s.io/v1
date: "2025-04-21T15:21:21Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
  contact: null
  organization: API7
  project: api7-ingress-controller
  url: https://github.com/api7/api7-ingress-controller.git
  version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
    result: partial
    skippedTests:
    - GatewayInvalidTLSConfiguration
    - GatewaySecretInvalidReferenceGrant
    - GatewaySecretMissingReferenceGrant
    - GatewaySecretReferenceGrantAllInNamespace
    - GatewaySecretReferenceGrantSpecific
    - HTTPRouteExactPathMatching
    - HTTPRouteHTTPSListener
    - HTTPRouteHeaderMatching
    - HTTPRouteHostnameIntersection
    - HTTPRouteInvalidBackendRefUnknownKind
    - HTTPRouteInvalidCrossNamespaceBackendRef
    - HTTPRouteInvalidCrossNamespaceParentRef
    - HTTPRouteInvalidNonExistentBackendRef
    - HTTPRouteInvalidParentRefNotMatchingSectionName
    - HTTPRouteInvalidReferenceGrant
    - HTTPRouteListenerHostnameMatching
    - HTTPRouteMatching
    - HTTPRouteMatchingAcrossRoutes
    - HTTPRoutePartiallyInvalidViaInvalidReferenceGrant
    - HTTPRouteReferenceGrant
    - HTTPRouteRequestHeaderModifier
    - HTTPRouteWeight
    statistics:
      Failed: 0
      Passed: 11
      Skipped: 22
  name: GATEWAY-HTTP
  summary: Core tests partially succeeded with 22 test skips.

@ronething ronething requested review from AlinsRan and Copilot April 22, 2025 01:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the conformance test by patching the gateway proxy to align with the gateway infrastructure. Key changes include:

  • Adding a controller-runtime client (K8sClient) to the e2e framework.
  • Implementing namespace deletion and automated patching of gateways with a GatewayProxy reference in the conformance tests.
  • Introducing utilities for applying and cleaning up GatewayProxy resources.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
test/e2e/framework/framework.go Added initialization for a controller-runtime client (K8sClient).
test/conformance/suite_test.go Added functions for namespace deletion and gateway patching to support conformance testing.

AdminEndpoint: framework.DashboardTLSEndpoint,
}

patchGatewaysForConformanceTest(context.Background(), f.K8sClient)
Copy link

Copilot AI Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a cancellable context instead of context.Background() when starting the patching goroutine to allow for proper termination and resource cleanup after tests.

Copilot uses AI. Check for mistakes.
@ronething ronething merged commit fee56d5 into release-v2-dev Apr 22, 2025
8 checks passed
@ronething ronething deleted the fix/conformance_test branch April 22, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants