Skip to content

Conversation

@ronething
Copy link
Contributor

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: ashing <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025

conformance test report

apiVersion: gateway.networking.k8s.io/v1
date: "2025-04-30T13:43:56Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
  contact: null
  organization: API7
  project: api7-ingress-controller
  url: https://github.com/api7/api7-ingress-controller.git
  version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
    failedTests:
    - HTTPRouteHeaderMatching
    result: failure
    skippedTests:
    - GatewayInvalidTLSConfiguration
    - GatewaySecretInvalidReferenceGrant
    - GatewaySecretMissingReferenceGrant
    - HTTPRouteHTTPSListener
    - HTTPRouteHostnameIntersection
    - HTTPRouteInvalidBackendRefUnknownKind
    - HTTPRouteInvalidCrossNamespaceBackendRef
    - HTTPRouteInvalidCrossNamespaceParentRef
    - HTTPRouteInvalidNonExistentBackendRef
    - HTTPRouteInvalidParentRefNotMatchingSectionName
    - HTTPRouteInvalidReferenceGrant
    - HTTPRouteListenerHostnameMatching
    - HTTPRouteMatching
    - HTTPRouteMatchingAcrossRoutes
    - HTTPRoutePartiallyInvalidViaInvalidReferenceGrant
    - HTTPRouteReferenceGrant
    statistics:
      Failed: 1
      Passed: 16
      Skipped: 16
  name: GATEWAY-HTTP
  summary: Core tests failed with 1 test failures.

@ronething ronething requested review from AlinsRan and Copilot May 6, 2025 01:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to help pass more conformance tests by updating namespaces, refining the skipped tests list, ensuring consistent JSON serialization, and setting a timeout for the conformance test workflow.

  • Added a new namespace ("api7ee-conformance-test") for deletion during test setup.
  • Reordered and removed duplicate/commented skipped test entries.
  • Updated JSON/YAML tags to include "omitempty" and configured a 60‑minute timeout in the GitHub action.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
test/conformance/suite_test.go Added new namespace to be deleted in the test setup
test/conformance/conformance_test.go Reordered and refined the test skip list for clarity and maintainability
api/adc/types.go Added "omitempty" to JSON/YAML tags to clean up output serialization
.github/workflows/conformance-test.yml Configured a 60‑minute timeout for the conformance test job
Files not reviewed (1)
  • Makefile: Language not supported
Comments suppressed due to low confidence (2)

api/adc/types.go:421

  • The addition of 'omitempty' ensures cleaner JSON/YAML outputs for empty fields; verify that downstream consumers are compatible with this change.
Set    map[string]string `json:"set,omitempty" yaml:"set,omitempty"`

.github/workflows/conformance-test.yml:42

  • Confirm that a 60‑minute timeout is sufficient for your conformance tests given current performance trends.
timeout-minutes: 60

"gateway-conformance-infra",
"gateway-conformance-web-backend",
"gateway-conformance-app-backend",
"api7ee-conformance-test",
Copy link

Copilot AI May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the addition of the new namespace 'api7ee-conformance-test' is intentional and that the corresponding deletion logic in conformance tests handles it appropriately.

Suggested change
"api7ee-conformance-test",
// "api7ee-conformance-test", // Uncomment if this namespace is intentionally used in the tests.

Copilot uses AI. Check for mistakes.

var skippedTestsForTraditionalRoutes = []string{
// TODO: Support ReferenceGrant resource
tests.GatewaySecretInvalidReferenceGrant.ShortName,
Copy link

Copilot AI May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Review the reordering and removal of skipped test entries for consistency; consider removing commented-out duplicates to improve list clarity.

Copilot uses AI. Check for mistakes.
@ronething ronething merged commit d07a2ec into release-v2-dev May 6, 2025
8 checks passed
@ronething ronething deleted the fix/pass_more_test branch May 6, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants