-
Notifications
You must be signed in to change notification settings - Fork 2
feat: support proxy external service #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
conformance test reportapiVersion: gateway.networking.k8s.io/v1
date: "2025-04-22T10:11:55Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: API7
project: api7-ingress-controller
url: https://github.com/api7/api7-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
failedTests:
- HTTPRouteCrossNamespace
result: failure
skippedTests:
- GatewayInvalidTLSConfiguration
- GatewaySecretInvalidReferenceGrant
- GatewaySecretMissingReferenceGrant
- GatewaySecretReferenceGrantAllInNamespace
- GatewaySecretReferenceGrantSpecific
- HTTPRouteExactPathMatching
- HTTPRouteHTTPSListener
- HTTPRouteHeaderMatching
- HTTPRouteHostnameIntersection
- HTTPRouteInvalidBackendRefUnknownKind
- HTTPRouteInvalidCrossNamespaceBackendRef
- HTTPRouteInvalidCrossNamespaceParentRef
- HTTPRouteInvalidNonExistentBackendRef
- HTTPRouteInvalidParentRefNotMatchingSectionName
- HTTPRouteInvalidReferenceGrant
- HTTPRouteListenerHostnameMatching
- HTTPRouteMatching
- HTTPRouteMatchingAcrossRoutes
- HTTPRoutePartiallyInvalidViaInvalidReferenceGrant
- HTTPRouteReferenceGrant
- HTTPRouteRequestHeaderModifier
- HTTPRouteWeight
statistics:
Failed: 1
Passed: 10
Skipped: 22
name: GATEWAY-HTTP
summary: Core tests failed with 1 test failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for proxying ExternalName services. Key changes include:
- Adding end-to-end tests for ExternalName service support in both Ingress and HTTPRoute resources.
- Updating the ADC translator logic in both ingress and httproute to properly handle ExternalName services.
- Adjusting controller logic to detect and process ExternalName service types appropriately.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/ingress/ingress.go | Added tests for proxying ExternalName service in Ingress. |
| test/e2e/gatewayapi/httproute.go | Added tests for HTTPRoute ExternalName service proxy support. |
| internal/provider/adc/translator/ingress.go | Augmented translation for ExternalName services in Ingress. |
| internal/provider/adc/translator/httproute.go | Incorporated ExternalName service logic for HTTPRoute. |
| internal/controller/ingress_controller.go | Adjusted backend service processing for ExternalName service. |
| internal/controller/httproute_controller.go | Updated HTTPRoute backend reference processing for ExternalName. |
Comments suppressed due to low confidence (1)
test/e2e/ingress/ingress.go:219
- [nitpick] Duplicate log statement 'By("create GatewayProxy")' appears in the test. Consider removing or updating the redundant message to improve test output clarity.
By("create GatewayProxy")
ronething
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Type of change:
What this PR does / why we need it:
support service with ExternalName
Pre-submission checklist: