Skip to content

Conversation

@ronething
Copy link
Contributor

@ronething ronething commented Apr 25, 2025

  • Avoid downloading the helm chart every time when run test.

@ronething ronething requested review from AlinsRan and Copilot April 25, 2025 03:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to optimize the test process by avoiding repeated downloads of the Helm chart during test runs.

  • Removed the on-demand chart download in the test framework by using an environment variable.
  • Added workflow steps to install Helm and download the API7EE3 chart for both e2e and conformance tests.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
test/e2e/framework/dashboard.go Replaced dynamic chart location with environment variable lookup and added error handling.
.github/workflows/e2e-test.yml Added steps for installing Helm and downloading the API7EE3 chart.
.github/workflows/conformance-test.yml Added similar steps for Helm install and API7EE3 chart download; note inconsistency in step naming.
Files not reviewed (1)
  • Makefile: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/conformance-test.yml:90

  • [nitpick] The step name 'Install API7EE3' is inconsistent with the 'Download API7EE3 Chart' naming used in the e2e-test workflow. Consider renaming it for consistency.
- name: Install API7EE3

@ronething ronething changed the title chore(ci): add helm download chore(ci): add api7ee3 chart download step. Apr 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025

conformance test report

apiVersion: gateway.networking.k8s.io/v1
date: "2025-04-25T11:14:52Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
  contact: null
  organization: API7
  project: api7-ingress-controller
  url: https://github.com/api7/api7-ingress-controller.git
  version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
    result: partial
    skippedTests:
    - GatewayInvalidTLSConfiguration
    - GatewaySecretInvalidReferenceGrant
    - GatewaySecretMissingReferenceGrant
    - GatewaySecretReferenceGrantAllInNamespace
    - GatewaySecretReferenceGrantSpecific
    - HTTPRouteExactPathMatching
    - HTTPRouteHTTPSListener
    - HTTPRouteHeaderMatching
    - HTTPRouteHostnameIntersection
    - HTTPRouteInvalidBackendRefUnknownKind
    - HTTPRouteInvalidCrossNamespaceBackendRef
    - HTTPRouteInvalidCrossNamespaceParentRef
    - HTTPRouteInvalidNonExistentBackendRef
    - HTTPRouteInvalidParentRefNotMatchingSectionName
    - HTTPRouteInvalidReferenceGrant
    - HTTPRouteListenerHostnameMatching
    - HTTPRouteMatching
    - HTTPRouteMatchingAcrossRoutes
    - HTTPRoutePartiallyInvalidViaInvalidReferenceGrant
    - HTTPRouteReferenceGrant
    - HTTPRouteRequestHeaderModifier
    - HTTPRouteWeight
    statistics:
      Failed: 0
      Passed: 11
      Skipped: 22
  name: GATEWAY-HTTP
  summary: Core tests partially succeeded with 22 test skips.

Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
@ronething ronething merged commit 7548a22 into release-v2-dev Apr 27, 2025
7 checks passed
@ronething ronething deleted the fix/helm_download branch April 27, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants