fix: conformance test case: HTTPRouteInvalidCrossNamespaceParentRef #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the logic for setting HTTPRoute status conditions by introducing helper functions and improving cross-namespace validation. The changes include refactoring condition status updates, adding proper namespace checks for ParentRef, and streamlining the status update process in the HTTPRoute controller.
dspo
changed the title
…ance-test-case-HTTPRouteInvalidCrossNamespaceParentRef # Conflicts: # internal/controller/utils.go # test/conformance/conformance_test.go
Contributor
conformance test reportapiVersion: gateway.networking.k8s.io/v1
date: "2025-05-13T08:52:48Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: APISIX
project: apisix-ingress-controller
url: https://github.com/apache/apisix-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
result: partial
skippedTests:
- GatewayInvalidTLSConfiguration
- GatewaySecretInvalidReferenceGrant
- GatewaySecretMissingReferenceGrant
- HTTPRouteHTTPSListener
- HTTPRouteInvalidCrossNamespaceBackendRef
- HTTPRouteInvalidReferenceGrant
- HTTPRoutePartiallyInvalidViaInvalidReferenceGrant
- HTTPRouteReferenceGrant
statistics:
Failed: 0
Passed: 25
Skipped: 8
name: GATEWAY-HTTP
summary: Core tests partially succeeded with 8 test skips. |
Removed hardcoded conformance tests and introduced a dedicated function `SetRouteConditionResolvedRefs` for managing resolved references conditions. Additionally, disabled an unstable test case related to HTTPRoutePolicy status changes for further investigation.
dspo
changed the title
Re-enable the `HTTPRouteInvalidBackendRefUnknownKind` test case by uncommenting it, while also commenting out two other test cases (`HTTPRouteMatching` and `HTTPRouteMatchingAcrossRoutes`) to adjust the test suite configuration. These changes refine the test selection to focus on specific conformance scenarios.
AlinsRan
approved these changes
May 13, 2025
ronething
reviewed
May 13, 2025
…ance-test-case-HTTPRouteInvalidCrossNamespaceParentRef # Conflicts: # internal/controller/httproute_controller.go # internal/controller/utils.go # test/conformance/conformance_test.go
ronething
reviewed
May 13, 2025
…ance-test-case-HTTPRouteInvalidCrossNamespaceParentRef # Conflicts: # test/conformance/conformance_test.go
ronething
approved these changes
May 13, 2025
dspo
deleted the
fix/conformance-test-case-HTTPRouteInvalidCrossNamespaceParentRef
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix test case:
https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/tests/httproute-invalid-cross-namespace-parent-ref.go#L35-L70
Simplify the logic for setting HTTPRoute status conditions by introducing helper functions and improving cross-namespace validation. The changes include refactoring condition status updates, adding proper namespace checks for ParentRef, and streamlining the status update process in the HTTPRoute controller.
Type of change:
What this PR does / why we need it:
Pre-submission checklist: