-
Notifications
You must be signed in to change notification settings - Fork 2
feat: ready for opensource #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prepares the project for open source by rebranding the repository from API7 to APISIX, updating image and repository references, and removing several legacy and proprietary files such as certain dashboard API types, test workflows, and documentation. Key changes include:
- Replacing repository and image names across configuration, Makefile, and workflow files.
- Removing legacy test workflows (E2E and Conformance tests) and select API-related files (plugin_types.go and doc.go).
- Updating comments and documentation to reflect the new branding.
Reviewed Changes
Copilot reviewed 87 out of 87 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/provider/adc/translator/gateway.go | Updated comment wording for wildcard hostname handling |
| internal/controller/gateway_controller.go | Removed duplicate log import |
| go.mod | Adjusted dependency list and updated indirect module requirements |
| docs/quickstart.md | Deleted outdated quickstart guide |
| docs/gateway-api.md & docs/concepts.md | Updated product naming to "APISIX Gateway" |
| config/manager/kustomization.yaml | Updated image repository for the controller |
| cmd/root/root.go | Removed obsolete dashboard SDK log comment |
| charts/values.yaml | Updated image repository name accordingly |
| api/dashboard/v1/plugin_types.go & doc.go | Removed API dashboard type and documentation files |
| README.md | Updated repository references and deployment instructions |
| Makefile | Updated image variable and removed deprecated e2e test targets |
| .github/workflows/release-drafter.yml | Updated condition for repository name |
| .github/workflows/e2e-test.yml & conformance-test.yml | Completely removed legacy workflow files |
Comments suppressed due to low confidence (2)
Makefile:105
- The removal of several e2e test targets may reduce automated test coverage; please confirm that these tests have been migrated elsewhere or are no longer required.
Removal of e2e test targets
api/dashboard/v1/plugin_types.go:1
- Removing the plugin_types.go file is a significant change; please confirm that its definitions are now handled in another location or that this removal is intentional.
Entire file removal
| Key: string(key), | ||
| }) | ||
| // Dashboard doesn't allow wildcard hostname | ||
| // we doesn't allow wildcard hostname |
Copilot
AI
May 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment contains a grammatical error ('we doesn't'); consider revising it to 'APISIX Gateway does not allow wildcard hostnames' for clarity and consistency.
| // we doesn't allow wildcard hostname | |
| // APISIX Gateway does not allow wildcard hostnames |
modify/remove files:
search result: