Skip to content

Conversation

@ronething
Copy link
Contributor

@ronething ronething commented May 21, 2025

modify/remove files:

.github/workflows/conformance-test.yml
.github/workflows/e2e-test.yml
.github/workflows/release-drafter.yml
.gitignore
Makefile
README.md
api/dashboard/v1/doc.go
api/dashboard/v1/plugin_types.go
api/dashboard/v1/types.go
api/dashboard/v1/zz_generated.deepcopy.go
api/v1alpha1/backendtrafficpolicy_types.go
api/v1alpha1/consumer_types.go
api/v1alpha1/gatewayproxy_types.go
api/v1alpha1/httproutepolicy_types.go
charts/values.yaml
cmd/root/root.go
config/manager/kustomization.yaml
docs/concepts.md
docs/gateway-api.md
docs/quickstart.md
go.mod
go.sum
internal/provider/adc/translator/gateway.go
internal/provider/controlplane/controlplane.go
internal/provider/controlplane/manifest.go
internal/provider/controlplane/translator/gateway.go
internal/provider/controlplane/translator/httproute.go
internal/provider/controlplane/translator/translator.go
pkg/dashboard/cache/cache.go
pkg/dashboard/cache/memdb.go
pkg/dashboard/cache/memdb_test.go
pkg/dashboard/cache/noop_db.go
pkg/dashboard/cache/schema.go
pkg/dashboard/cluster.go
pkg/dashboard/consumer.go
pkg/dashboard/consumer_test.go
pkg/dashboard/dashboard.go
pkg/dashboard/global_rule.go
pkg/dashboard/nonexistentclient.go
pkg/dashboard/noop.go
pkg/dashboard/plugin.go
pkg/dashboard/plugin_metadata.go
pkg/dashboard/plugin_test.go
pkg/dashboard/pluginconfig.go
pkg/dashboard/resource.go
pkg/dashboard/route.go
pkg/dashboard/schema.go
pkg/dashboard/service.go
pkg/dashboard/ssl.go
pkg/dashboard/stream_route.go
pkg/dashboard/utils.go
pkg/dashboard/validator.go
test/conformance/conformance_test.go
test/conformance/suite_test.go
test/e2e/adminapi/dashboard_api.go
test/e2e/crds/backendtrafficpolicy.go
test/e2e/crds/consumer.go
test/e2e/e2e_test.go
test/e2e/framework/consts.go
test/e2e/framework/dashboard.go
test/e2e/framework/database.go
test/e2e/framework/framework.go
test/e2e/framework/gateway.go
test/e2e/framework/ingress.go
test/e2e/framework/k8s.go
test/e2e/framework/license.go
test/e2e/framework/manifests/cert.pem
test/e2e/framework/manifests/dp.yaml
test/e2e/framework/manifests/ingress.yaml
test/e2e/framework/manifests/key.pem
test/e2e/framework/manifests/nginx.yaml
test/e2e/framework/nginx.go
test/e2e/framework/utils.go
test/e2e/gatewayapi/controller.go
test/e2e/gatewayapi/gateway.go
test/e2e/gatewayapi/gatewayclass.go
test/e2e/gatewayapi/gatewayproxy.go
test/e2e/gatewayapi/httproute.go
test/e2e/ingress/ingress.go
test/e2e/scaffold/dp.go
test/e2e/scaffold/httpbin.go
test/e2e/scaffold/ingress.go
test/e2e/scaffold/k8s.go
test/e2e/scaffold/scaffold.go
test/e2e/scaffold/ssl.go
test/utils/utils.go

search result:

$ grep -rnE 'dashboard|api7' .
./cmd/root/root.go:36:  "github.com/api7/gopkg/pkg/log"
./go.mod:8:     github.com/api7/gopkg v0.2.1-0.20230601092738-0f3730f9b57a
./Dockerfile:12:    && wget https://github.com/api7/adc/releases/download/v${ADC_VERSION}/adc_${ADC_VERSION}_linux_${TARGETARCH}.tar.gz -O adc.tar.gz \
./internal/provider/adc/config.go:19:   "github.com/api7/gopkg/pkg/log"
./internal/provider/adc/cache/memdb.go:18:      "github.com/api7/gopkg/pkg/log"
./internal/provider/adc/store.go:18:    "github.com/api7/gopkg/pkg/log"
./internal/provider/adc/translator/gateway.go:22:       "github.com/api7/gopkg/pkg/log"
./internal/provider/adc/translator/ingressclass.go:16:  "github.com/api7/gopkg/pkg/log"
./internal/provider/adc/translator/httproute.go:20:     "github.com/api7/gopkg/pkg/log"
./internal/provider/adc/adc.go:25:      "github.com/api7/gopkg/pkg/log"
./internal/provider/adc/adc.go:330:             "ADC_BACKEND=api7ee",
./internal/controller/ingressclass_controller.go:19:    "github.com/api7/gopkg/pkg/log"
./internal/controller/utils.go:25:      "github.com/api7/gopkg/pkg/log"
./internal/controller/ingress_controller.go:21: "github.com/api7/gopkg/pkg/log"
./internal/controller/gateway_controller.go:21: "github.com/api7/gopkg/pkg/log"
./internal/controller/httproute_controller.go:20:       "github.com/api7/gopkg/pkg/log"
./go.sum:4:github.com/api7/gopkg v0.2.1-0.20230601092738-0f3730f9b57a h1:YtrVQEEaw8/nu+qeGHwZq2DMVdEwHTTNsa5VvPZljSA=
./go.sum:5:github.com/api7/gopkg v0.2.1-0.20230601092738-0f3730f9b57a/go.mod h1:kAbMwxeaiBpGsa1WvD2+UTq2tQBiT+ht5r5H/8onEDY=
./docs/concepts.md:7:![APISIX Ingress Controller Architecture](./assets/images/api7-ingress-controller-architecture.png)
./Dockerfile.dev:12:    && git clone --branch main https://github.com/api7/adc.git \

@ronething ronething requested a review from Copilot May 21, 2025 06:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the project for open source by rebranding the repository from API7 to APISIX, updating image and repository references, and removing several legacy and proprietary files such as certain dashboard API types, test workflows, and documentation. Key changes include:

  • Replacing repository and image names across configuration, Makefile, and workflow files.
  • Removing legacy test workflows (E2E and Conformance tests) and select API-related files (plugin_types.go and doc.go).
  • Updating comments and documentation to reflect the new branding.

Reviewed Changes

Copilot reviewed 87 out of 87 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/provider/adc/translator/gateway.go Updated comment wording for wildcard hostname handling
internal/controller/gateway_controller.go Removed duplicate log import
go.mod Adjusted dependency list and updated indirect module requirements
docs/quickstart.md Deleted outdated quickstart guide
docs/gateway-api.md & docs/concepts.md Updated product naming to "APISIX Gateway"
config/manager/kustomization.yaml Updated image repository for the controller
cmd/root/root.go Removed obsolete dashboard SDK log comment
charts/values.yaml Updated image repository name accordingly
api/dashboard/v1/plugin_types.go & doc.go Removed API dashboard type and documentation files
README.md Updated repository references and deployment instructions
Makefile Updated image variable and removed deprecated e2e test targets
.github/workflows/release-drafter.yml Updated condition for repository name
.github/workflows/e2e-test.yml & conformance-test.yml Completely removed legacy workflow files
Comments suppressed due to low confidence (2)

Makefile:105

  • The removal of several e2e test targets may reduce automated test coverage; please confirm that these tests have been migrated elsewhere or are no longer required.
Removal of e2e test targets

api/dashboard/v1/plugin_types.go:1

  • Removing the plugin_types.go file is a significant change; please confirm that its definitions are now handled in another location or that this removal is intentional.
Entire file removal

Key: string(key),
})
// Dashboard doesn't allow wildcard hostname
// we doesn't allow wildcard hostname
Copy link

Copilot AI May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment contains a grammatical error ('we doesn't'); consider revising it to 'APISIX Gateway does not allow wildcard hostnames' for clarity and consistency.

Suggested change
// we doesn't allow wildcard hostname
// APISIX Gateway does not allow wildcard hostnames

Copilot uses AI. Check for mistakes.
@ronething ronething changed the base branch from release-v2-dev to ingress-opensource May 21, 2025 07:08
@ronething ronething changed the title (Don't Merge)feat: ready for opensource feat: ready for ingress opensource May 21, 2025
@ronething ronething changed the title feat: ready for ingress opensource feat: ready for opensource May 21, 2025
@ronething ronething marked this pull request as ready for review May 21, 2025 07:09
@ronething ronething merged commit 5dad202 into ingress-opensource May 21, 2025
5 checks passed
@ronething ronething deleted the opensource branch May 21, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants