Skip to content

Conversation

@ronething
Copy link
Contributor

@ronething ronething commented Jun 6, 2025

In many test cases, framework.DashboardTLSEndpoint was used directly. Now, the GetAdminEndpoint method is provided for processing, to adapt to different test modes.

@ronething ronething changed the title fix: get admin endpoint fix: add GetAdminEndpoint method for deployer Jun 6, 2025
@ronething ronething requested a review from Copilot June 6, 2025 02:12
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

conformance test report

apiVersion: gateway.networking.k8s.io/v1
date: "2025-06-06T02:24:10Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
  contact: null
  organization: APISIX
  project: apisix-ingress-controller
  url: https://github.com/apache/apisix-ingress-controller.git
  version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
    result: partial
    skippedTests:
    - HTTPRouteHTTPSListener
    statistics:
      Failed: 0
      Passed: 32
      Skipped: 1
  name: GATEWAY-HTTP
  summary: Core tests partially succeeded with 1 test skips.

@ronething ronething requested a review from AlinsRan June 6, 2025 02:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Introduce a unified GetAdminEndpoint abstraction for deployers and update tests to use it instead of framework.DashboardTLSEndpoint.

  • Add GetAdminEndpoint to GatewayResources and Deployer interface
  • Implement the method in APISIXDeployer and API7Deployer
  • Replace all direct uses of framework.DashboardTLSEndpoint in E2E tests with s.Deployer.GetAdminEndpoint()

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/e2e/scaffold/scaffold.go Added GetAdminEndpoint on GatewayResources
test/e2e/scaffold/k8s.go Switched to s.Deployer.GetAdminEndpoint()
test/e2e/scaffold/deployer.go Extended Deployer interface with GetAdminEndpoint
test/e2e/scaffold/apisix_deployer.go Implemented GetAdminEndpoint for APISIXDeployer
test/e2e/scaffold/api7_deployer.go Implemented GetAdminEndpoint for API7Deployer
test/e2e/ingress/ingress.go Updated gatewayProxy instantiation calls
test/e2e/gatewayapi/httproute.go Updated gatewayProxy instantiation and additional gateway calls
test/e2e/gatewayapi/gatewayproxy.go Removed framework import, switched to deployer API
test/e2e/gatewayapi/gateway.go Updated gatewayProxy instantiation calls
test/e2e/gatewayapi/controller.go Updated gatewayProxy instantiation calls
test/e2e/crds/consumer.go Updated updatedProxy instantiation call
test/e2e/crds/backendtrafficpolicy.go Updated gatewayProxy instantiation call
Comments suppressed due to low confidence (2)

test/e2e/scaffold/apisix_deployer.go:340

  • Ensure the fmt package (and corev1 if not already imported) is added at the top of this file; otherwise fmt.Sprintf and corev1.Service become unresolved.
func (s *APISIXDeployer) GetAdminEndpoint(svc ...*corev1.Service) string {

test/e2e/scaffold/scaffold.go:84

  • [nitpick] The new GetAdminEndpoint on GatewayResources isn’t used by the test scaffolding; consider removing it or updating calls to use resources.GetAdminEndpoint() directly for consistency.
func (g *GatewayResources) GetAdminEndpoint() string {

@ronething ronething merged commit 9a9af12 into release-v2-dev Jun 6, 2025
11 checks passed
@ronething ronething deleted the fix/dashboard_endpoint branch June 6, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants