-
Notifications
You must be signed in to change notification settings - Fork 2
backport: apisix ingress pr #2480 #2473 #2492 #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds custom metrics support to the APISIX Ingress Controller, implementing Prometheus-style metrics for monitoring ADC sync operations, file I/O performance, and status update queue management. Additionally, it upgrades the Go version from 1.22 to 1.23 across the project.
- Implements comprehensive Prometheus metrics for ADC operations, file I/O, and status queue monitoring
- Adds metrics endpoint exposure through Kubernetes service configuration
- Integrates metrics collection throughout the ADC sync workflow and status update processes
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/metrics/metrics.go | New metrics package defining Prometheus metrics for ADC sync, file I/O, and status operations |
| internal/provider/adc/adc.go | Integrates metrics collection into ADC sync operations with timing and error tracking |
| internal/controller/status/updater.go | Adds queue length tracking for status update operations |
| test/e2e/scaffold/scaffold.go | Adds helper method to expose metrics endpoint for testing |
| test/e2e/apisix/route.go | Implements e2e test validation for metrics endpoint functionality |
| test/e2e/framework/manifests/ingress.yaml | Configures metrics port exposure in Kubernetes service and deployment |
| test/e2e/framework/manifests/apisix.yaml | Adds control port configuration for APISIX container |
| go.mod | Upgrades Go version to 1.23 and promotes prometheus client to direct dependency |
| README.md | Updates Go version requirement documentation |
| .github/workflows/*.yml | Updates CI/CD workflows to use Go 1.23 |
conformance test report - apisix-standalone modeapiVersion: gateway.networking.k8s.io/v1
date: "2025-07-25T08:38:56Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: APISIX
project: apisix-ingress-controller
url: https://github.com/apache/apisix-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
failedTests:
- HTTPRouteMatchingAcrossRoutes
result: failure
skippedTests:
- HTTPRouteHTTPSListener
statistics:
Failed: 1
Passed: 31
Skipped: 1
name: GATEWAY-HTTP
summary: Core tests failed with 1 test failures. |
conformance test report - apisix modeapiVersion: gateway.networking.k8s.io/v1
date: "2025-07-25T08:40:09Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: APISIX
project: apisix-ingress-controller
url: https://github.com/apache/apisix-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
failedTests:
- HTTPRouteInvalidBackendRefUnknownKind
result: failure
skippedTests:
- HTTPRouteHTTPSListener
statistics:
Failed: 1
Passed: 31
Skipped: 1
name: GATEWAY-HTTP
summary: Core tests failed with 1 test failures. |
conformance test reportapiVersion: gateway.networking.k8s.io/v1
date: "2025-07-25T08:35:56Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: APISIX
project: apisix-ingress-controller
url: https://github.com/apache/apisix-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
result: partial
skippedTests:
- HTTPRouteHTTPSListener
statistics:
Failed: 0
Passed: 32
Skipped: 1
name: GATEWAY-HTTP
summary: Core tests partially succeeded with 1 test skips. |
* chore: differentiate the API versions for CRD testing * revert ingress.go * update test * update test Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Co-authored-by: AlinsRan <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Type of change:
What this PR does / why we need it:
backport #2480 #2473 #2492 from apisix-ingress-controller repo.
Pre-submission checklist: