feat: fallback to endpoints when endpointslice disable #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashing Zheng <[email protected]>
Signed-off-by: Ashing Zheng <[email protected]>
Signed-off-by: Ashing Zheng <[email protected]>
Contributor
conformance test report - apisix-standalone modeapiVersion: gateway.networking.k8s.io/v1
date: "2025-08-01T07:10:48Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: APISIX
project: apisix-ingress-controller
url: https://github.com/apache/apisix-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
result: partial
skippedTests:
- HTTPRouteHTTPSListener
statistics:
Failed: 0
Passed: 32
Skipped: 1
name: GATEWAY-HTTP
summary: Core tests partially succeeded with 1 test skips. |
Contributor
conformance test report - apisix modeapiVersion: gateway.networking.k8s.io/v1
date: "2025-08-01T07:12:54Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: APISIX
project: apisix-ingress-controller
url: https://github.com/apache/apisix-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
failedTests:
- HTTPRouteMatchingAcrossRoutes
result: failure
skippedTests:
- HTTPRouteHTTPSListener
statistics:
Failed: 1
Passed: 31
Skipped: 1
name: GATEWAY-HTTP
summary: Core tests failed with 1 test failures. |
Contributor
conformance test reportapiVersion: gateway.networking.k8s.io/v1
date: "2025-08-01T07:14:26Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: APISIX
project: apisix-ingress-controller
url: https://github.com/apache/apisix-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
result: partial
skippedTests:
- HTTPRouteHTTPSListener
statistics:
Failed: 0
Passed: 32
Skipped: 1
name: GATEWAY-HTTP
summary: Core tests partially succeeded with 1 test skips. |
Signed-off-by: Ashing Zheng <[email protected]>
Signed-off-by: Ashing Zheng <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds fallback support for Kubernetes 1.18 clusters by implementing compatibility with the Endpoints API when EndpointSlice API is not available. The implementation detects EndpointSlice API support at runtime and gracefully falls back to using Endpoints API for service discovery.
Key Changes:
- Added runtime detection of EndpointSlice API availability and fallback to Endpoints API
- Created utility function to convert Endpoints to EndpointSlice format for internal consistency
- Updated RBAC permissions to include endpoints resource access
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/utils/endpoints.go | New utility function to convert Endpoints objects to EndpointSlice format |
| pkg/utils/cluster.go | Updated API resource detection to use controller-runtime's apiutil |
| internal/controller/*.go | Added EndpointSlice support detection and conditional watching/processing |
| test/e2e/framework/manifests/ingress.yaml | Added endpoints RBAC permissions |
| config/rbac/role.yaml | Updated RBAC role to include endpoints access |
| test/e2e/crds/v2/route.go | Refactored test assertion method call |
Signed-off-by: Ashing Zheng <[email protected]>
Signed-off-by: Ashing Zheng <[email protected]>
Signed-off-by: Ashing Zheng <[email protected]>
AlinsRan
reviewed
Aug 1, 2025
| predicate.Or( | ||
| predicate.GenerationChangedPredicate{}, | ||
| predicate.AnnotationChangedPredicate{}, | ||
| predicate.NewPredicateFuncs(TypePredicate[*corev1.Endpoints]()), |
Contributor
There was a problem hiding this comment.
When supportsEndpointSlice is true, it is redundant.
AlinsRan
reviewed
Aug 1, 2025
| terr = err | ||
| continue | ||
| // Conditionally collect EndpointSlice or Endpoints based on cluster API support | ||
| if r.supportsEndpointSlice { |
Contributor
There was a problem hiding this comment.
Can this logic be abstracted into a function for reuse.
AlinsRan
reviewed
Aug 1, 2025
pkg/utils/endpoints.go
Outdated
|
|
||
| for i, subset := range ep.Subsets { | ||
| // Create ports array | ||
| var ports []discoveryv1.EndpointPort |
AlinsRan
approved these changes
Aug 1, 2025
Signed-off-by: Ashing Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Pre-submission checklist: