Skip to content

fix: port name should always set to endpointPortName #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2025
Merged

fix: port name should always set to endpointPortName #224

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a138771
fix: port name should always set to endpointPortName
ronething Aug 5, 2025
9a5c661
fix: r
ronething Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pkg/utils/endpoints.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,7 @@ func ConvertEndpointsToEndpointSlice(ep *corev1.Endpoints) []discoveryv1.Endpoin
epPort := discoveryv1.EndpointPort{
Port: &p.Port,
Protocol: &p.Protocol,
}
if p.Name != "" {
epPort.Name = &p.Name
Name: &p.Name,
}
ports = append(ports, epPort)
}
Expand Down
Loading