feat: support SSL #52
Conversation
|
@AlinsRan Can you take a look at again at certificate extraction? I have taken reference from |
|
@AlinsRan Currently E2E tests are in dysfunctional state. So for the completion of this subtask, the passing tests need to be there or not? |
|
@Revolyssup At present, e2e testing is mainly focused on basic functions. |
The test cases you wrote yourself are all incorrect. I suggest you run them locally:
|
|
locally the tests passing. trying to fix the ci issue |
|
@AlinsRan E2E test passing, need to pass conformance test |
|
We also need a use case for accessing HTTPS based on |
test/conformance/conformance_test.go
Outdated
| var skippedTestsForTraditionalRoutes = []string{ | ||
| // TODO: Support ReferenceGrant resource | ||
| tests.HTTPRouteInvalidReferenceGrant.ShortName, | ||
| tests.GatewayWithAttachedRoutes.ShortName, |
There was a problem hiding this comment.
One test in this was failing. Trying to pass it now
| continue | ||
| } | ||
| secret := corev1.Secret{} | ||
| for _, ref := range listener.TLS.CertificateRefs { |
There was a problem hiding this comment.
Need condition ref.kind == secret
| Snis: []string{}, | ||
| } | ||
| name := listener.TLS.CertificateRefs[0].Name | ||
| secret := tctx.Secrets[types.NamespacedName{Namespace: ns, Name: string(ref.Name)}] |
No description provided.