Skip to content

Conversation

@dspo
Copy link
Contributor

@dspo dspo commented Apr 16, 2025

Moved the Vars and StringOrSlice types from the common package to the adc package to better encapsulate related functionality. Updated import paths and references accordingly to reflect this change.

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

dspo added 2 commits April 16, 2025 10:51
Moved the `Vars` and `StringOrSlice` types from the `common` package to the `adc` package to better encapsulate related functionality. Updated import paths and references accordingly to reflect this change.
Removed unnecessary descriptions and complex types for the `Vars` field, replacing them with a simpler `[]apiextensionsv1.JSON` type. Also, updated the deep copy logic to handle the new type, and removed unused imports.
@github-actions
Copy link
Contributor

conformance test report

apiVersion: gateway.networking.k8s.io/v1
date: "2025-04-16T03:15:33Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
  contact: null
  organization: API7
  project: api7-ingress-controller
  url: https://github.com/api7/api7-ingress-controller.git
  version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
    failedTests:
    - HTTPRoutePathMatchOrder
    - HTTPRouteServiceTypes
    result: failure
    skippedTests:
    - GatewayInvalidTLSConfiguration
    - GatewaySecretInvalidReferenceGrant
    - GatewaySecretMissingReferenceGrant
    - GatewaySecretReferenceGrantAllInNamespace
    - GatewaySecretReferenceGrantSpecific
    - HTTPRouteExactPathMatching
    - HTTPRouteHTTPSListener
    - HTTPRouteHeaderMatching
    - HTTPRouteHostnameIntersection
    - HTTPRouteInvalidBackendRefUnknownKind
    - HTTPRouteInvalidCrossNamespaceBackendRef
    - HTTPRouteInvalidCrossNamespaceParentRef
    - HTTPRouteInvalidNonExistentBackendRef
    - HTTPRouteInvalidParentRefNotMatchingSectionName
    - HTTPRouteInvalidReferenceGrant
    - HTTPRouteListenerHostnameMatching
    - HTTPRouteMatching
    - HTTPRouteMatchingAcrossRoutes
    - HTTPRoutePartiallyInvalidViaInvalidReferenceGrant
    - HTTPRouteReferenceGrant
    - HTTPRouteRequestHeaderModifier
    - HTTPRouteWeight
    statistics:
      Failed: 2
      Passed: 9
      Skipped: 22
  name: GATEWAY-HTTP
  summary: Core tests failed with 2 test failures.

@dspo dspo requested a review from Copilot April 16, 2025 03:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

api/adc/types.go:530

  • The definition of StringOrSlice has been changed so that the SliceVal field is now declared as []StringOrSlice instead of []string as in the previous implementation. This recursive type declaration could lead to unintended behavior; please confirm if this change is intentional or update it to []string if the original logic was intended.
SliceVal []StringOrSlice `json:"-"`

@dspo dspo merged commit 497da5f into release-v2-dev Apr 16, 2025
8 checks passed
@AlinsRan AlinsRan deleted the chore/string-or-slice branch May 8, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants