Skip to content

Conversation

@dspo
Copy link
Contributor

@dspo dspo commented Apr 20, 2025

Refactor the HTTPRoutePolicy update function to handle Ingress objects and improve logging. Add functionality to process HTTPRoutePolicies for Ingress in the IngressReconciler. Update tests to include scenarios for HTTPRoutePolicy targeting Ingress.

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Refactor the HTTPRoutePolicy update function to handle Ingress objects and improve logging. Add functionality to process HTTPRoutePolicies for Ingress in the IngressReconciler. Update tests to include scenarios for HTTPRoutePolicy targeting Ingress.
@dspo dspo requested a review from Copilot April 21, 2025 01:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors HTTPRoutePolicy handling for Ingress by updating the update function, adding corresponding tests, and enhancing logging.

  • Refactored resource translation and policy processing for Ingress.
  • Added E2E tests for HTTPRoutePolicy targeting Ingress.
  • Updated indexers and controller event handling to support the new Ingress policy workflow.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/e2e/ingress/ingress.go Added comprehensive E2E tests for HTTPRoutePolicy handling on Ingress.
internal/provider/adc/translator/ingress.go Updated Ingress translation to integrate HTTPRoutePolicy processing.
internal/provider/adc/translator/httproute.go Refactored HTTPRoutePolicy functions to separate Ingress and HTTPRoute paths.
internal/controller/ingress_controller.go Introduced generic event handling and Ingress-specific HTTPRoutePolicy logic.
internal/controller/indexer/indexer.go Added a new index for HTTPRoutePolicy targetRefs on Ingress.
internal/controller/httproutepolicy.go Added policy processing for Ingress and refactored conflict handling.
internal/controller/httproute_controller.go Updated event predicates and object key fetching in HTTPRoute reconciliation.

@dspo dspo merged commit 11d4805 into release-v2-dev Apr 21, 2025
7 of 8 checks passed
@AlinsRan AlinsRan deleted the feat/httproutepolicy-ingress branch May 8, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants