Skip to content

Conversation

@B4nan
Copy link
Member

@B4nan B4nan commented Nov 19, 2024

No description provided.

@B4nan B4nan requested a review from vladfrangu as a code owner November 19, 2024 10:28
@github-actions github-actions bot added this to the 103rd sprint - Tooling team milestone Nov 19, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 19, 2024
docId: 'index',
label: 'Docs',
position: 'left',
activeBaseRegex: 'docs(?!/changelog|/reference)',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not working correctly, especially for the next version, but I spent way too much time on this one line that it's no longer justified

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@B4nan B4nan added the adhoc Ad-hoc unplanned task added during the sprint. label Nov 19, 2024
@B4nan B4nan requested a review from TC-MO as a code owner November 19, 2024 10:54
{
type: 'docsVersionDropdown',
position: 'left',
className: 'navbar__item', // fixes margin around dropdown - hackish, should be fixed in theme
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this fixed in theme already?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk, maybe @barjin knows? its copied from the SDK

@B4nan B4nan merged commit c1fb97f into master Nov 19, 2024
17 checks passed
@B4nan B4nan deleted the versioned-docs branch November 19, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants