Skip to content

chore: Do not install poetry in install-dev make target #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2024
Merged

chore: Do not install poetry in install-dev make target #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e238439
Do not install poetry in install-dev make target
janbuchar Sep 5, 2024
9eea5ad
Install poetry in CI
janbuchar Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/check_async_docstrings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ jobs:
python-version: 3.8

- name: Install dependencies
run: make install-dev
run: |
pipx install poetry
make install-dev

- name: Check async docstrings
run: make check-async-docstrings
4 changes: 3 additions & 1 deletion .github/workflows/check_version_availability.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ jobs:
python-version: "3.8"

- name: Install dependencies
run: make install-dev
run: |
pipx install poetry
make install-dev

- name: Check version availability
run: make check-version-availability
6 changes: 4 additions & 2 deletions .github/workflows/docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,10 @@ jobs:
with:
python-version: 3.8

- name: Install Python dependencies
run: make install-dev
- name: Install dependencies
run: |
pipx install poetry
make install-dev

- name: Build generated API reference
run: make build-api-reference
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/integration_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: make install-dev
run: |
pipx install poetry
make install-dev

- name: Run integration tests
run: make INTEGRATION_TESTS_CONCURRENCY=8 integration-tests
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/lint_and_type_checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: make install-dev
run: |
pipx install poetry
make install-dev

- name: Run lint
run: make lint
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ jobs:
python-version: 3.8

- name: Install dependencies
run: make install-dev
run: |
pipx install poetry
make install-dev

- # Determine if this is a prerelease or latest release
name: Determine release type
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/unit_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: make install-dev
run: |
pipx install poetry
make install-dev

- name: Run unit tests
run: make unit-tests
1 change: 0 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ clean:
rm -rf .mypy_cache .pytest_cache .ruff_cache build dist htmlcov .coverage

install-dev:
python3 -m pip install --upgrade pip poetry
poetry install --all-extras
poetry run pre-commit install

Expand Down