-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Add charge method to the run client for "pay per event" #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fde68cd
Add charge to run client
Jkuzz 037090f
Add sync method and make them work
Jkuzz 01b09ba
response.json
Jkuzz 7f18ac1
format
Jkuzz d912d6e
correct self class
Jkuzz 25e7e00
Fix types, add todo url
Jkuzz 4b656a8
Guess the docs URL
Jkuzz aec0b3c
Update src/apify_client/clients/resource_clients/run.py
Jkuzz 0bf8a55
Update src/apify_client/clients/resource_clients/run.py
Jkuzz f074945
Add suffix to idempotency key
Jkuzz 58d2674
fix f string
Jkuzz f3ddf59
Also change sync method
Jkuzz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if someone tries to charge for two occurences of one event twice in the same millisecond? Then the idempotency key will be the same and one charge will get ignored. Some unique key is needed here, I think a random string would be enough.
There's a
crypto_random_object_id
implementation in Crawlee for Python, perhaps we could move it toapify-shared-python
and use it here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the idempotency key generation from https://github.com/apify-store/contact-info/blob/master/code/src/charging_manager.ts but it could be specific to their actors 🤔 I can move
crypto_random_object_id
👍