-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Add error data to ApifyApiError #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
19e4a35
Add error data to ApifyApiError
Pijukatel 6b811c0
Pyproject.toml
Pijukatel 83e272f
Replace usefixtures by autouse
Pijukatel 9318bb3
Merge remote-tracking branch 'origin/master' into dataset-schema-vali…
Pijukatel 43161eb
Not so restrictive bounds for httpx
Pijukatel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
import json | ||
|
||
import httpx | ||
import pytest | ||
import respx | ||
from respx import MockRouter | ||
|
||
from apify_client._errors import ApifyApiError | ||
from apify_client._http_client import HTTPClient, HTTPClientAsync | ||
|
||
_TEST_URL = 'http://example.com' | ||
_EXPECTED_MESSAGE = 'some_message' | ||
_EXPECTED_TYPE = 'some_type' | ||
_EXPECTED_DATA = { | ||
'invalidItems': {'0': ["should have required property 'name'"], '1': ["should have required property 'name'"]} | ||
} | ||
|
||
|
||
@respx.mock | ||
@pytest.fixture(autouse=True) | ||
def mocked_response(respx_mock: MockRouter) -> None: | ||
response_content = json.dumps( | ||
{'error': {'message': _EXPECTED_MESSAGE, 'type': _EXPECTED_TYPE, 'data': _EXPECTED_DATA}} | ||
) | ||
respx_mock.get(_TEST_URL).mock(return_value=httpx.Response(400, content=response_content)) | ||
|
||
|
||
def test_client_apify_api_error_with_data() -> None: | ||
"""Test that client correctly throws ApifyApiError with error data from response.""" | ||
client = HTTPClient() | ||
|
||
with pytest.raises(ApifyApiError) as e: | ||
client.call(method='GET', url=_TEST_URL) | ||
|
||
assert e.value.message == _EXPECTED_MESSAGE | ||
assert e.value.type == _EXPECTED_TYPE | ||
assert e.value.data == _EXPECTED_DATA | ||
|
||
|
||
async def test_async_client_apify_api_error_with_data() -> None: | ||
"""Test that async client correctly throws ApifyApiError with error data from response.""" | ||
client = HTTPClientAsync() | ||
|
||
with pytest.raises(ApifyApiError) as e: | ||
await client.call(method='GET', url=_TEST_URL) | ||
|
||
assert e.value.message == _EXPECTED_MESSAGE | ||
assert e.value.type == _EXPECTED_TYPE | ||
assert e.value.data == _EXPECTED_DATA |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.