Add DynamicTimeoutFunction
#383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
|
|
||
| For POST on endpoint v2/datasets/whatever/items timeout is proportional to the size of the content. | ||
| For everything else return fixed 30.""" | ||
| if isinstance(content, bytes) and method == 'POST' and url.endswith('v2/datasets/whatever/items'): |
There was a problem hiding this comment.
The dynamic timeout function only handles content that is of type bytes, but the tests pass strings (e.g., 'abcd'). To ensure the expected custom timeouts (e.g., 5, 9), update the type check or convert the content to bytes.
| ('content', 'expected_timeout'), | ||
| [ | ||
| pytest.param('abcd', 5, id='Small payload'), | ||
| pytest.param('abcd' * 10000, 9, id='Payload in the dynamic timeout interval interval'), |
There was a problem hiding this comment.
[nitpick] The test case id contains a repeated phrase ('interval interval'); consider revising it to remove the duplication.
Suggested change
| pytest.param('abcd' * 10000, 9, id='Payload in the dynamic timeout interval interval'), | |
| pytest.param('abcd' * 10000, 9, id='Payload in the dynamic timeout interval'), |
Contributor
Author
|
Close din favor of: #384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
DynamicTimeoutFunctionto enable custom timeouts for individual requests.This allows users of
ApifyClientAsyncandApifyClientto pass optional argumentget_dynamic_timeoutwhich is a function that can get suitable timeout for http requests to Apify API. Clients will use this function to set timeout for the requests.Clients behave the same as before if the optional argument is not used.
Enables fix of: apify/crawlee-python#1132