feat: allow sorting of Actors collection #422
Merged
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protoss70
added
the
t-integrations
tobice
approved these changes
Jun 16, 2025
vdusek
requested changes
Jun 17, 2025
Contributor
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Looks good 🙂 , just one note regarding the docstrings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new sorting param sortBy for the new feature described in this Issue
I will wait until Apify-Core PR is deployed and then will merge this.
One note, I am not sure if I added the sortBy parameter correctly. Example code below:
return await self._list(my=my, limit=limit, offset=offset, desc=desc, sortBy=sort_by)I tried to follow similar examples with a camel case api parameter. Please let me know if this is not the correct syntax.