fix: Presigned resource urls shouldn't follow base url #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
barjin
reviewed
Sep 10, 2025
Co-authored-by: Jindřich Bär <[email protected]>
barjin
approved these changes
Sep 11, 2025
Comment on lines
68
to
69
| assert kvs_client._url() == f'{non_existent_url}/v2/key-value-stores/{kvs_name}' | ||
| assert kvs_client._url(public=True) == f'{DEFAULT_API_URL}/v2/key-value-stores/{kvs_name}' |
There was a problem hiding this comment.
nit: should we test _-prefixed methods?
There was a problem hiding this comment.
Fair point, I wanted to avoid mocking the API calls, but that was actually the correct approach. I reworked the tests.
barjin
reviewed
Sep 11, 2025
tests/integration/conftest.py
Outdated
| ('https://api.apify.com', 'https://custom-public-url.com'), | ||
| ('https://api.apify.com', 'https://custom-public-url.com/with/custom/path'), | ||
| ('https://api.apify.com', 'https://custom-public-url.com/with/custom/path/'), | ||
| ('http://10.0.88.214:8010', 'https://api.apify.com'), |
There was a problem hiding this comment.
I hate to be a stickler for detail, but now we're testing this:
client = ApifyClient(base_url="10.0.0...", public_base_url="https://api.apify.com")
assert "api.apify.com" in client.kvs.public_url() While the failing case from the original issue would be something like
client = ApifyClient(base_url="10.0.0...") # no public url passed, only base
assert "api.apify.com" in client.kvs.public_url() # yet, this assert still passesNot that it really matters, but I wanted to propose this with the previous commit and ultimately revoked my comment, because I noticed this difference :)
janbuchar
reviewed
Sep 11, 2025
janbuchar
reviewed
Sep 12, 2025
janbuchar
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
baseUrlapify-client-js#745Issues
Testing