Skip to content

Conversation

@barjin
Copy link
Contributor

@barjin barjin commented Sep 9, 2024

Docusaurus v3 adds the onBrokenAnchors setting that allows us to fail the build when Docusaurus finds broken anchor links (internal fragment links).

Closes #952

@barjin barjin self-assigned this Sep 9, 2024
@github-actions github-actions bot added this to the 98th sprint - Tooling team milestone Sep 9, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Sep 9, 2024
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for merge,
Changed to warn it still shows a lot of API ref links but they work when clicked manually, all other broken anchors have been fixed

@barjin
Copy link
Contributor Author

barjin commented Oct 8, 2024

Looking good to me, thank you and feel free to merge @TC-MO 👍🏽 Given that this fixes broken links, I don't think anybody's gonna object 😄

@TC-MO TC-MO merged commit ec5b323 into master Oct 8, 2024
7 checks passed
@TC-MO TC-MO deleted the chore/throw-on-broken-anchors branch October 8, 2024 08:38
@TC-MO
Copy link
Contributor

TC-MO commented Oct 8, 2024

Yeah I doubt anyone would object to 100+ fixed links :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check broken anchors

3 participants