Skip to content

Conversation

@vdusek
Copy link
Contributor

@vdusek vdusek commented Nov 5, 2024

No description provided.

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Nov 5, 2024
@vdusek vdusek added this to the 102nd sprint - Tooling team milestone Nov 5, 2024
@vdusek vdusek requested a review from B4nan November 5, 2024 08:50
@vdusek vdusek self-assigned this Nov 5, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

If issue is not linked to the pull request then estimate the pull request!

@B4nan
Copy link
Member

B4nan commented Nov 5, 2024

@fnesveda could you take a peek at this? we don't have any redirects for crawlee here just yet, so not sure if its fine like this

Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe I would move the rewrite after the locations to keep it consistent with the first server block, it should have no functional difference.

@vdusek vdusek merged commit 39c0cd2 into master Nov 5, 2024
8 checks passed
@vdusek vdusek deleted the add-redirect-crawlee-python branch November 5, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants