Skip to content

fix: space between header and flags added #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2024
Merged

fix: space between header and flags added #1286

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28036aa
fix: add spacing between header and flags
HonzaKirchner Nov 13, 2024
5c9efc3
fix
HonzaKirchner Nov 13, 2024
cb9110f
margin applied to the right classes
HonzaKirchner Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apify-docs-theme/src/theme/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,10 @@ article .card h2 {
user-select: none;
}

.tsd-flag-group {
Copy link
Member

@B4nan B4nan Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesnt look right, we already have margin on the group, its missing on tsd-flag

image image

for tsd-flag we want just margin-right, it has a negative top margin and you would override it this way

Copy link
Member

@B4nan B4nan Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm the screen above is parameters, but the one in OP is on higher level (method name). this will be probably more tricky, you will need to target this better most likely.

try to debug this directly on the SDK docs so you can see how things end up visually. you can run them separately.

Copy link
Member Author

@HonzaKirchner HonzaKirchner Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh.. I see.
Should be fixed now ✅
CleanShot 2024-11-18 at 13 00 30@2x

margin: 0 .5rem;
}

.tsd-panel .tsd-flag {
color: #f2f3fb;
}
Expand Down