fix: ensure correct position of old anchors in API docs #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-tooling
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
TC-MO
approved these changes
Nov 13, 2024
Contributor
TC-MO
left a comment
TC-MO
left a comment
There was a problem hiding this comment.
Should there be a bigger audit to double check all API links?
janbuchar
approved these changes
Nov 13, 2024
Member
Author
Most likely, this is fixing the one I know about, but more importantly, it fixes the anchor position. Then there is a separate issue you were facing with the scroll happening too fast and you end up at the bottom anyway, but first we need to have correct anchor position and correct link. FYI I went through all dataset links in the docs from this repo and this is the only one that was in wrong format without the middle part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.