Skip to content

fix: remove possible infinite loop in the changelog transformation #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix: remove possible infinite loop in the changelog transformation #1452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions apify-docs-theme/src/markdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const remarkParse = require('remark-parse');
const remarkStringify = require('remark-stringify');
const { unified } = require('unified');
const { visitParents } = require('unist-util-visit-parents');
const { visitParents, CONTINUE } = require('unist-util-visit-parents');

/**
* Bumps the headings levels in the markdown content. This function increases the depth
Expand Down Expand Up @@ -40,7 +40,7 @@ const linkifyUserTags = () => (tree) => {

const directParent = parents[parents.length - 1];

if (!match || directParent.type === 'link') return 0;
if (!match || directParent.type === 'link') return CONTINUE;

const nodeIndexInParent = directParent.children.findIndex((x) => x === node);

Expand All @@ -57,10 +57,10 @@ const linkifyUserTags = () => (tree) => {
node.value = before;
directParent.children.splice(nodeIndexInParent + 1, 0, link);

if (!after) return nodeIndexInParent + 2;
if (!after) return [CONTINUE, nodeIndexInParent + 2];

directParent.children.splice(nodeIndexInParent + 2, 0, { type: 'text', value: `${ending}${after}` });
return nodeIndexInParent + 3;
return [CONTINUE, nodeIndexInParent + 3];
});
};

Expand All @@ -75,7 +75,7 @@ const prettifyPRLinks = () => (tree) => {
const prLinkRegex = /https:\/\/github.com\/[^\s]+\/pull\/(\d+)/g;
const match = prLinkRegex.exec(node.value);

if (!match) return 0;
if (!match) return CONTINUE;

const directParent = parents[parents.length - 1];
const nodeIndexInParent = directParent.children.findIndex((x) => x === node);
Expand All @@ -92,10 +92,10 @@ const prettifyPRLinks = () => (tree) => {
node.value = before;

directParent.children.splice(nodeIndexInParent + 1, 0, link);
if (!after) return nodeIndexInParent + 1;
if (!after) return [CONTINUE, nodeIndexInParent + 1];

directParent.children.splice(nodeIndexInParent + 2, 0, { type: 'text', value: after });
return nodeIndexInParent + 2;
return [CONTINUE, nodeIndexInParent + 2];
});
};

Expand Down