Skip to content

feat: mastra mcp agent #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 27, 2025
Merged

feat: mastra mcp agent #1505

merged 11 commits into from
Mar 27, 2025

Conversation

@MQ37
Copy link
Contributor

@MQ37 MQ37 commented Mar 21, 2025 •
edited
Loading

Will be merged after the timeout MCP option is released for @mastra/mcp npm package.

@github-actions github-actions bot added the t-ai Issues owned by the AI team. label Mar 21, 2025
@MQ37 MQ37 marked this pull request as ready for review March 21, 2025 14:40
@MQ37 MQ37 requested a review from TC-MO as a code owner March 21, 2025 14:40
@MQ37 MQ37 requested a review from jirispilka March 21, 2025 14:40
@MQ37
Copy link
Contributor Author

MQ37 commented Mar 24, 2025

closes #1507

TC-MO
TC-MO requested changes Mar 24, 2025
View reviewed changes
@MQ37
Copy link
Contributor Author

MQ37 commented Mar 24, 2025

@TC-MO Thank you for review and suggestions 👍

@MQ37 MQ37 requested a review from TC-MO March 26, 2025 10:52
TC-MO
TC-MO approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment that came to me after re-reading. We are mentioning that Mastra is capable of integrating with various LLMs but provide an example and mentions as prerequisites only OpenAI. Maybe it would make sense to make it a bit more platform agnostic?

TC-MO
TC-MO reviewed Mar 26, 2025
View reviewed changes
@MQ37
Copy link
Contributor Author

MQ37 commented Mar 26, 2025

LGTM, just one comment that came to me after re-reading. We are mentioning that Mastra is capable of integrating with various LLMs but provide an example and mentions as prerequisites only OpenAI. Maybe it would make sense to make it a bit more platform agnostic?

Thank you for suggestion 👍 Makes sense, made the guide more provider agnostic

@MQ37 MQ37 merged commit f6b1947 into master Mar 27, 2025
7 checks passed
@MQ37 MQ37 deleted the feat/mastra-mcp branch March 27, 2025 11:13
@jirispilka
Copy link
Contributor

jirispilka commented Mar 27, 2025

@MQ37 Thanks and I'm sorry for a delay with the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TC-MO TC-MO TC-MO approved these changes

@jirispilka jirispilka Awaiting requested review from jirispilka

Assignees

@MQ37 MQ37

Labels

t-ai Issues owned by the AI team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MQ37 @jirispilka @TC-MO