Skip to content

Conversation

@mhamas
Copy link
Contributor

@mhamas mhamas commented May 7, 2025

This PR is adding first version of documentation related to tiered pricing in Apify Store.

@mhamas mhamas requested a review from TC-MO as a code owner May 7, 2025 15:17
@github-actions github-actions bot added the t-c&c Team covering store and finance matters. label May 7, 2025
@mhamas mhamas requested a review from Jkuzz May 7, 2025 15:20
@mhamas mhamas requested a review from mnmkng May 8, 2025 10:57
@mhamas mhamas marked this pull request as draft May 9, 2025 07:31
@mhamas
Copy link
Contributor Author

mhamas commented May 9, 2025

Converting to draft to do one more pass after discussing with Ondra.

@mhamas
Copy link
Contributor Author

mhamas commented May 12, 2025

@mnmkng I addressed the change, the docs is ready for review.

@mhamas mhamas marked this pull request as ready for review May 12, 2025 12:48
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some rewrites for better flow ,clarity & language. I changed the example slightly as well to match the table so it is more anchored in the text. I also made formatting of the tier names unified across the whole doc.

Comment on lines 138 to 139
### Computing your costs for PPE and PPR Actors
For both PPE and PPR Actors, profit is computed using the formula `(0.8 * revenue) - costs`. In this section, we'll explain how the `costs` component is calculated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix mdlint

Suggested change
### Computing your costs for PPE and PPR Actors
For both PPE and PPR Actors, profit is computed using the formula `(0.8 * revenue) - costs`. In this section, we'll explain how the `costs` component is calculated.
### Computing your costs for PPE and PPR Actors
For both PPE and PPR Actors, profit is computed using the formula `(0.8 * revenue) - costs`. In this section, we'll explain how the `costs` component is calculated.

@mhamas
Copy link
Contributor Author

mhamas commented May 14, 2025

@TC-MO I addressed the comments, please can you re-review? Thx

@mhamas mhamas requested a review from TC-MO May 14, 2025 18:01
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nitpicks and one suggestion otherwise LGTM

@mhamas mhamas merged commit 6c8ca68 into master May 15, 2025
7 checks passed
@mhamas mhamas deleted the feat/tiered-pricing branch May 15, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-c&c Team covering store and finance matters.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants