Skip to content

Conversation

@barjin
Copy link
Member

@barjin barjin commented Jul 14, 2025

Utilizes docusaurus-plugin-image-zoom to add a simple zoom feature on all post images.

image image

@barjin barjin requested review from B4nan and TC-MO July 14, 2025 11:03
@barjin barjin self-assigned this Jul 14, 2025
@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Jul 14, 2025
@github-actions github-actions bot added this to the 119th sprint - Tooling team milestone Jul 14, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jul 14, 2025
@apify-service-account
Copy link

Preview for this PR was built for commit 03c95e1 and is ready at https://pr-1689.preview.docs.apify.com!

Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM works nicely on preview

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a problem when you click on an image link, e.g. try clicking on the images here, and you end up on a blank page with a "minus cursor", so it thinks you are in the zoomed image view apparently. we need to enable this only on images that are not inside links

@apify-service-account
Copy link

Preview for this PR was built for commit 4d6f01d and is ready at https://pr-1689.preview.docs.apify.com!

@B4nan
Copy link
Member

B4nan commented Jul 15, 2025

One more issue I found, when the image is too high, the second level navbar can cover the top of it:

https://pr-1689.preview.docs.apify.com/academy/web-scraping-for-beginners/crawling

image

Otherwise looking good.

cursor[bot]

This comment was marked as abuse.

@apify-service-account
Copy link

Preview for this PR was built for commit 26bd6fe8 and is ready at https://pr-1689.preview.docs.apify.com!

@barjin
Copy link
Member Author

barjin commented Jul 15, 2025

Cursor ⏫ is lying, the navbar z-index is 200 right now:

image

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

@barjin barjin merged commit 741af0f into master Jul 16, 2025
10 checks passed
@barjin barjin deleted the feat/zoomable-images branch July 16, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants