-
Notifications
You must be signed in to change notification settings - Fork 141
feat: use docusaurus-plugin-image-zoom to add zoomable images
#1689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview for this PR was built for commit |
TC-MO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM works nicely on preview
B4nan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a problem when you click on an image link, e.g. try clicking on the images here, and you end up on a blank page with a "minus cursor", so it thinks you are in the zoomed image view apparently. we need to enable this only on images that are not inside links
|
Preview for this PR was built for commit |
|
One more issue I found, when the image is too high, the second level navbar can cover the top of it: https://pr-1689.preview.docs.apify.com/academy/web-scraping-for-beginners/crawling
Otherwise looking good. |
|
Preview for this PR was built for commit |
B4nan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, lgtm


Utilizes
docusaurus-plugin-image-zoomto add a simple zoom feature on all post images.