-
Notifications
You must be signed in to change notification settings - Fork 141
docs: Fix titles based on discussion #1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview for this PR was built for commit |
TC-MO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change requested, IIRC we spoke in the previous thread about keeping sidebar label unchanged and changing just the page title
| title: Actor development | ||
| desc: Read about the technical part of building Apify Actors. Learn to define Actor inputs, build new versions, persist Actor state, and choose base Docker images. | ||
| sidebar_position: 7.4 | ||
| slug: /actors/development |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add sidebar_label: Development to frontmatter? I don't think placement matters much, but for consistency I would prefer under description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And based on this discussion can we get Account settings instead of Console settings
|
@TC-MO thanks for the review. I updated the sidebar label based on your proposal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment bugbot run to trigger another review on this PR
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
TC-MO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll make separate PR for Account settings
This is a follow up for the PR: #1751. Some titles need to improve as I did not wait for @TC-MO - sorry!