Skip to content

Conversation

patrikbraborec
Copy link
Contributor

The following changes edit the PPE documentation based on feedback from @metalwarrior665 and also based on Discord discussion.

@apify-service-account
Copy link

Preview for this PR was built for commit de33912 and is ready at https://pr-1936.preview.docs.apify.com!

@TC-MO
Copy link
Contributor

TC-MO commented Sep 18, 2025

That added section kind of feels like it should be within Best practices WDYT?

@patrikbraborec
Copy link
Contributor Author

patrikbraborec commented Sep 18, 2025

No, we agreed with Lukas that it should be rather outside the Best practices as it is must have, and not the best practice. But the title can be changed, etc.

@TC-MO
Copy link
Contributor

TC-MO commented Sep 18, 2025

Cool that was just first thought, thanks for context I'll do thorough review of language and IA later today

Copy link
Member

@metalwarrior665 metalwarrior665 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see any issues, thanks!

@metalwarrior665
Copy link
Member

It is not a new section, I just suggested to Patrik to move it before the Best practices section. The rest is just removing the main function wrapper in examples

Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apify-service-account
Copy link

Preview for this PR was built for commit b1dc387 and is ready at https://pr-1936.preview.docs.apify.com!

@patrikbraborec patrikbraborec merged commit 9651b98 into master Sep 22, 2025
11 checks passed
@patrikbraborec patrikbraborec deleted the docs/ppe-updates branch September 22, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants